From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQtiB-0001Dw-0X for qemu-devel@nongnu.org; Thu, 07 Jun 2018 08:08:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQti7-0003J5-PT for qemu-devel@nongnu.org; Thu, 07 Jun 2018 08:08:14 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35814 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fQti7-0003Ii-KU for qemu-devel@nongnu.org; Thu, 07 Jun 2018 08:08:11 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1DDB7818BAF3 for ; Thu, 7 Jun 2018 12:08:11 +0000 (UTC) Date: Thu, 7 Jun 2018 14:08:09 +0200 From: Igor Mammedov Message-ID: <20180607140809.4159614b@redhat.com> In-Reply-To: <20180607102121.9849-1-dgilbert@redhat.com> References: <20180607102121.9849-1-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 4/6] hmp: Add info commands for preconfig List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: qemu-devel@nongnu.org, armbru@redhat.com, berrange@redhat.com On Thu, 7 Jun 2018 11:21:21 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Allow a bunch of the info commands to be used in preconfig. > Could probably add most of them. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Igor Mammedov > --- > hmp-commands-info.hx | 12 ++++++++++++ > hmp-commands.hx | 1 + > 2 files changed, 13 insertions(+) > > diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx > index ddfcd5adcc..f4d0d7d2d0 100644 > --- a/hmp-commands-info.hx > +++ b/hmp-commands-info.hx > @@ -19,6 +19,7 @@ ETEXI > .params = "", > .help = "show the version of QEMU", > .cmd = hmp_info_version, > + .flags = "p", > }, > > STEXI > @@ -47,6 +48,7 @@ ETEXI > .params = "", > .help = "show the character devices", > .cmd = hmp_info_chardev, > + .flags = "p", > }, > > STEXI > @@ -165,6 +167,7 @@ ETEXI > .params = "", > .help = "show the command line history", > .cmd = hmp_info_history, > + .flags = "p", > }, > > STEXI > @@ -315,6 +318,7 @@ ETEXI > .params = "", > .help = "show NUMA information", > .cmd = hmp_info_numa, > + .flags = "p", > }, > > STEXI > @@ -343,6 +347,7 @@ ETEXI > .params = "", > .help = "show host USB devices", > .cmd = hmp_info_usbhost, > + .flags = "p", > }, > > STEXI > @@ -399,6 +404,7 @@ ETEXI > .params = "", > .help = "show the current VM status (running|paused)", > .cmd = hmp_info_status, > + .flags = "p", > }, > > STEXI > @@ -457,6 +463,7 @@ ETEXI > .params = "", > .help = "show the current VM name", > .cmd = hmp_info_name, > + .flags = "p", > }, > > STEXI > @@ -471,6 +478,7 @@ ETEXI > .params = "", > .help = "show the current VM UUID", > .cmd = hmp_info_uuid, > + .flags = "p", > }, > > STEXI > @@ -613,6 +621,7 @@ ETEXI > .params = "[path]", > .help = "show QOM composition tree", > .cmd = hmp_info_qom_tree, > + .flags = "p", > }, > > STEXI > @@ -671,6 +680,7 @@ ETEXI > .params = "", > .help = "show memory backends", > .cmd = hmp_info_memdev, > + .flags = "p", > }, > > STEXI > @@ -699,6 +709,7 @@ ETEXI > .params = "", > .help = "show iothreads", > .cmd = hmp_info_iothreads, > + .flags = "p", > }, > > STEXI > @@ -829,6 +840,7 @@ ETEXI > .params = "", > .help = "Show information about hotpluggable CPUs", > .cmd = hmp_hotpluggable_cpus, > + .flags = "p", > }, > > STEXI > diff --git a/hmp-commands.hx b/hmp-commands.hx > index 8bf590ae4b..dc82ed526f 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -1856,6 +1856,7 @@ ETEXI > .help = "show various information about the system state", > .cmd = hmp_info_help, > .sub_table = info_cmds, > + .flags = "p", > }, > > STEXI