qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kurz <groug@kaod.org>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Greg Kurz <groug@kaod.org>,
	Keno Fischer <keno@juliacomputing.com>
Subject: [Qemu-devel] [PULL 2/7] 9p: local: Properly set errp in fstatfs error path
Date: Thu,  7 Jun 2018 17:21:14 +0200	[thread overview]
Message-ID: <20180607152119.3447-3-groug@kaod.org> (raw)
In-Reply-To: <20180607152119.3447-1-groug@kaod.org>

From: Keno Fischer <keno@juliacomputing.com>

In the review of

    9p: Avoid warning if FS_IOC_GETVERSION is not defined

Grep Kurz noted this error path was failing to set errp.
Fix that.

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
[added local: to commit title, Greg Kurz]
Signed-off-by: Greg Kurz <groug@kaod.org>
---
 hw/9pfs/9p-local.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c
index b37b1db453da..7758c3850900 100644
--- a/hw/9pfs/9p-local.c
+++ b/hw/9pfs/9p-local.c
@@ -1418,6 +1418,8 @@ static int local_init(FsContext *ctx, Error **errp)
      */
     if (fstatfs(data->mountfd, &stbuf) < 0) {
         close_preserve_errno(data->mountfd);
+        error_setg_errno(errp, errno,
+            "failed to stat file system at '%s'", ctx->fs_root);
         goto err;
     }
     switch (stbuf.f_type) {
-- 
2.14.4

  parent reply	other threads:[~2018-06-07 15:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-07 15:21 [Qemu-devel] [PULL 0/7] 9p patches 2018-06-07 Greg Kurz
2018-06-07 15:21 ` [Qemu-devel] [PULL 1/7] 9p: proxy: Fix size passed to `connect` Greg Kurz
2018-06-07 15:21 ` Greg Kurz [this message]
2018-06-07 15:21 ` [Qemu-devel] [PULL 3/7] 9p: Move a couple xattr functions to 9p-util Greg Kurz
2018-06-07 15:21 ` [Qemu-devel] [PULL 4/7] 9p: xattr: Fix crashes due to free of uninitialized value Greg Kurz
2018-06-07 15:21 ` [Qemu-devel] [PULL 5/7] 9p: local: Avoid warning if FS_IOC_GETVERSION is not defined Greg Kurz
2018-06-07 15:21 ` [Qemu-devel] [PULL 6/7] 9p: Properly check/translate flags in unlinkat Greg Kurz
2018-06-07 15:21 ` [Qemu-devel] [PULL 7/7] 9p: xattr: Properly translate xattrcreate flags Greg Kurz
2018-06-08  9:25 ` [Qemu-devel] [PULL 0/7] 9p patches 2018-06-07 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180607152119.3447-3-groug@kaod.org \
    --to=groug@kaod.org \
    --cc=keno@juliacomputing.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).