* [Qemu-devel] [PATCH] gitignore: Ignore qapi/qapi-*-job.[ch]
@ 2018-06-07 14:43 Yaowei Bai
2018-06-07 15:05 ` Jeff Cody
0 siblings, 1 reply; 3+ messages in thread
From: Yaowei Bai @ 2018-06-07 14:43 UTC (permalink / raw)
To: kwolf, jcody; +Cc: qemu-block, qemu-devel, Yaowei Bai
They were introduced by commit bf42508f24ee(job: Introduce
qapi/job.json) but forgot to ignore them in .gitignore.
Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
---
.gitignore | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/.gitignore b/.gitignore
index a178e4c..e4bacc6 100644
--- a/.gitignore
+++ b/.gitignore
@@ -36,6 +36,7 @@
/qapi/qapi-commands-common.[ch]
/qapi/qapi-commands-crypto.[ch]
/qapi/qapi-commands-introspect.[ch]
+/qapi/qapi-commands-job.[ch]
/qapi/qapi-commands-migration.[ch]
/qapi/qapi-commands-misc.[ch]
/qapi/qapi-commands-net.[ch]
@@ -53,6 +54,7 @@
/qapi/qapi-events-common.[ch]
/qapi/qapi-events-crypto.[ch]
/qapi/qapi-events-introspect.[ch]
+/qapi/qapi-events-job.[ch]
/qapi/qapi-events-migration.[ch]
/qapi/qapi-events-misc.[ch]
/qapi/qapi-events-net.[ch]
@@ -71,6 +73,7 @@
/qapi/qapi-types-common.[ch]
/qapi/qapi-types-crypto.[ch]
/qapi/qapi-types-introspect.[ch]
+/qapi/qapi-types-job.[ch]
/qapi/qapi-types-migration.[ch]
/qapi/qapi-types-misc.[ch]
/qapi/qapi-types-net.[ch]
@@ -88,6 +91,7 @@
/qapi/qapi-visit-common.[ch]
/qapi/qapi-visit-crypto.[ch]
/qapi/qapi-visit-introspect.[ch]
+/qapi/qapi-visit-job.[ch]
/qapi/qapi-visit-migration.[ch]
/qapi/qapi-visit-misc.[ch]
/qapi/qapi-visit-net.[ch]
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] gitignore: Ignore qapi/qapi-*-job.[ch]
2018-06-07 14:43 [Qemu-devel] [PATCH] gitignore: Ignore qapi/qapi-*-job.[ch] Yaowei Bai
@ 2018-06-07 15:05 ` Jeff Cody
2018-06-07 15:25 ` Yaowei Bai
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Cody @ 2018-06-07 15:05 UTC (permalink / raw)
To: Yaowei Bai; +Cc: kwolf, qemu-block, qemu-devel, eblake
On Thu, Jun 07, 2018 at 10:43:59AM -0400, Yaowei Bai wrote:
> They were introduced by commit bf42508f24ee(job: Introduce
> qapi/job.json) but forgot to ignore them in .gitignore.
>
> Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
Good patch, but Eric Blake already sent an identical one that has two r-b's
on it already, so that is probably the one to pull in:
[Qemu-block] [PATCH] block: Ignore generated job QAPI files
essage-Id: <20180531212435.165261-1-eblake@redhat.com>
Thanks,
Jeff
> ---
> .gitignore | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index a178e4c..e4bacc6 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -36,6 +36,7 @@
> /qapi/qapi-commands-common.[ch]
> /qapi/qapi-commands-crypto.[ch]
> /qapi/qapi-commands-introspect.[ch]
> +/qapi/qapi-commands-job.[ch]
> /qapi/qapi-commands-migration.[ch]
> /qapi/qapi-commands-misc.[ch]
> /qapi/qapi-commands-net.[ch]
> @@ -53,6 +54,7 @@
> /qapi/qapi-events-common.[ch]
> /qapi/qapi-events-crypto.[ch]
> /qapi/qapi-events-introspect.[ch]
> +/qapi/qapi-events-job.[ch]
> /qapi/qapi-events-migration.[ch]
> /qapi/qapi-events-misc.[ch]
> /qapi/qapi-events-net.[ch]
> @@ -71,6 +73,7 @@
> /qapi/qapi-types-common.[ch]
> /qapi/qapi-types-crypto.[ch]
> /qapi/qapi-types-introspect.[ch]
> +/qapi/qapi-types-job.[ch]
> /qapi/qapi-types-migration.[ch]
> /qapi/qapi-types-misc.[ch]
> /qapi/qapi-types-net.[ch]
> @@ -88,6 +91,7 @@
> /qapi/qapi-visit-common.[ch]
> /qapi/qapi-visit-crypto.[ch]
> /qapi/qapi-visit-introspect.[ch]
> +/qapi/qapi-visit-job.[ch]
> /qapi/qapi-visit-migration.[ch]
> /qapi/qapi-visit-misc.[ch]
> /qapi/qapi-visit-net.[ch]
> --
> 1.8.3.1
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] gitignore: Ignore qapi/qapi-*-job.[ch]
2018-06-07 15:05 ` Jeff Cody
@ 2018-06-07 15:25 ` Yaowei Bai
0 siblings, 0 replies; 3+ messages in thread
From: Yaowei Bai @ 2018-06-07 15:25 UTC (permalink / raw)
To: Jeff Cody; +Cc: kwolf, qemu-block, qemu-devel, eblake
On Thu, Jun 07, 2018 at 11:05:58AM -0400, Jeff Cody wrote:
> On Thu, Jun 07, 2018 at 10:43:59AM -0400, Yaowei Bai wrote:
> > They were introduced by commit bf42508f24ee(job: Introduce
> > qapi/job.json) but forgot to ignore them in .gitignore.
> >
> > Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
>
> Good patch, but Eric Blake already sent an identical one that has two r-b's
> on it already, so that is probably the one to pull in:
OK, pls ignore this one.
>
>
> [Qemu-block] [PATCH] block: Ignore generated job QAPI files
> essage-Id: <20180531212435.165261-1-eblake@redhat.com>
>
> Thanks,
> Jeff
>
> > ---
> > .gitignore | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/.gitignore b/.gitignore
> > index a178e4c..e4bacc6 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -36,6 +36,7 @@
> > /qapi/qapi-commands-common.[ch]
> > /qapi/qapi-commands-crypto.[ch]
> > /qapi/qapi-commands-introspect.[ch]
> > +/qapi/qapi-commands-job.[ch]
> > /qapi/qapi-commands-migration.[ch]
> > /qapi/qapi-commands-misc.[ch]
> > /qapi/qapi-commands-net.[ch]
> > @@ -53,6 +54,7 @@
> > /qapi/qapi-events-common.[ch]
> > /qapi/qapi-events-crypto.[ch]
> > /qapi/qapi-events-introspect.[ch]
> > +/qapi/qapi-events-job.[ch]
> > /qapi/qapi-events-migration.[ch]
> > /qapi/qapi-events-misc.[ch]
> > /qapi/qapi-events-net.[ch]
> > @@ -71,6 +73,7 @@
> > /qapi/qapi-types-common.[ch]
> > /qapi/qapi-types-crypto.[ch]
> > /qapi/qapi-types-introspect.[ch]
> > +/qapi/qapi-types-job.[ch]
> > /qapi/qapi-types-migration.[ch]
> > /qapi/qapi-types-misc.[ch]
> > /qapi/qapi-types-net.[ch]
> > @@ -88,6 +91,7 @@
> > /qapi/qapi-visit-common.[ch]
> > /qapi/qapi-visit-crypto.[ch]
> > /qapi/qapi-visit-introspect.[ch]
> > +/qapi/qapi-visit-job.[ch]
> > /qapi/qapi-visit-migration.[ch]
> > /qapi/qapi-visit-misc.[ch]
> > /qapi/qapi-visit-net.[ch]
> > --
> > 1.8.3.1
> >
> >
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-07 15:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-07 14:43 [Qemu-devel] [PATCH] gitignore: Ignore qapi/qapi-*-job.[ch] Yaowei Bai
2018-06-07 15:05 ` Jeff Cody
2018-06-07 15:25 ` Yaowei Bai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).