qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, qemu-s390x@nongnu.org,
	Paolo Bonzini <pbonzini@redhat.com>,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>,
	Richard Henderson <rth@twiddle.net>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	david@redhat.com, Eduardo Habkost <ehabkost@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>,
	Alexander Graf <agraf@suse.de>, Cornelia Huck <cohuck@redhat.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Greg Kurz <groug@kaod.org>
Subject: [Qemu-devel] [PATCH v1 2/8] spapr: no need to verify the node
Date: Thu,  7 Jun 2018 18:52:12 +0200	[thread overview]
Message-ID: <20180607165218.9558-3-david@redhat.com> (raw)
In-Reply-To: <20180607165218.9558-1-david@redhat.com>

The node property can always be queried and the value has already been
verified in pc_dimm_realize().

Signed-off-by: David Hildenbrand <david@redhat.com>
---
 hw/ppc/spapr.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 2375cbee12..d038f3243e 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -3578,14 +3578,7 @@ static void spapr_machine_device_plug(HotplugHandler *hotplug_dev,
             error_setg(errp, "Memory hotplug not supported for this machine");
             return;
         }
-        node = object_property_get_uint(OBJECT(dev), PC_DIMM_NODE_PROP, errp);
-        if (*errp) {
-            return;
-        }
-        if (node < 0 || node >= MAX_NODES) {
-            error_setg(errp, "Invaild node %d", node);
-            return;
-        }
+        node = object_property_get_uint(OBJECT(dev), PC_DIMM_NODE_PROP, NULL);
 
         spapr_memory_plug(hotplug_dev, dev, node, errp);
     } else if (object_dynamic_cast(OBJECT(dev), TYPE_SPAPR_CPU_CORE)) {
-- 
2.17.0

  parent reply	other threads:[~2018-06-07 16:52 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-07 16:52 [Qemu-devel] [PATCH v1 0/8] pc/spapr/s390x: machine hotplug handler cleanups David Hildenbrand
2018-06-07 16:52 ` [Qemu-devel] [PATCH v1 1/8] pc: local error handling in hotplug handler functions David Hildenbrand
2018-06-08  8:04   ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-06-08  8:05     ` David Hildenbrand
2018-06-07 16:52 ` David Hildenbrand [this message]
2018-06-08  3:28   ` [Qemu-devel] [PATCH v1 2/8] spapr: no need to verify the node David Gibson
2018-06-08  7:34   ` Greg Kurz
2018-06-08  7:42     ` David Hildenbrand
2018-06-08  7:46       ` Greg Kurz
2018-06-08  7:48         ` David Hildenbrand
2018-06-08  8:07           ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-06-08  8:39             ` Igor Mammedov
2018-06-08  8:41               ` David Hildenbrand
2018-06-08  9:06                 ` Igor Mammedov
2018-06-08  9:24                   ` David Hildenbrand
2018-06-08 10:52                     ` Greg Kurz
2018-06-08 11:28                       ` David Hildenbrand
2018-06-08 11:31                         ` Cornelia Huck
2018-06-08 11:53                         ` Greg Kurz
2018-06-08  8:20         ` [Qemu-devel] " David Gibson
2018-06-08  8:24           ` David Hildenbrand
2018-06-07 16:52 ` [Qemu-devel] [PATCH v1 3/8] spapr: move all DIMM checks into spapr_memory_plug David Hildenbrand
2018-06-08  3:28   ` David Gibson
2018-06-08  8:05   ` Greg Kurz
2018-06-08  8:07     ` David Hildenbrand
2018-06-08  8:41       ` Igor Mammedov
2018-06-07 16:52 ` [Qemu-devel] [PATCH v1 4/8] spapr: local error handling in hotplug handler functions David Hildenbrand
2018-06-08  3:29   ` David Gibson
2018-06-08  8:40   ` Greg Kurz
2018-06-07 16:52 ` [Qemu-devel] [PATCH v1 5/8] spapr: introduce machine unplug handler David Hildenbrand
2018-06-08  3:29   ` David Gibson
2018-06-08  8:44   ` Igor Mammedov
2018-06-08  8:56   ` Greg Kurz
2018-06-07 16:52 ` [Qemu-devel] [PATCH v1 6/8] spapr: handle pc-dimm unplug via hotplug handler chain David Hildenbrand
2018-06-08  3:30   ` David Gibson
2018-06-08  8:56   ` Igor Mammedov
2018-06-08  9:02     ` David Hildenbrand
2018-06-08  9:35       ` Igor Mammedov
2018-06-08  9:36         ` David Hildenbrand
2018-06-08  8:59   ` Greg Kurz
2018-06-07 16:52 ` [Qemu-devel] [PATCH v1 7/8] spapr: handle cpu core " David Hildenbrand
2018-06-08  3:31   ` David Gibson
2018-06-08  8:57   ` Igor Mammedov
2018-06-08  9:00   ` Greg Kurz
2018-06-07 16:52 ` [Qemu-devel] [PATCH v1 8/8] s390x: local error handling in hotplug handler functions David Hildenbrand
2018-06-08  7:25   ` Cornelia Huck
2018-06-08  7:27     ` Christian Borntraeger
2018-06-08  7:40       ` David Hildenbrand
2018-06-08  7:50         ` Christian Borntraeger
2018-06-08  9:03         ` Igor Mammedov
2018-06-08  9:19           ` David Hildenbrand
2018-06-08  7:58 ` [Qemu-devel] [PATCH v1 0/8] pc/spapr/s390x: machine hotplug handler cleanups David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180607165218.9558-3-david@redhat.com \
    --to=david@redhat.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=ehabkost@redhat.com \
    --cc=groug@kaod.org \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).