From: Peter Xu <peterx@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, "Kevin Wolf" <kwolf@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Fam Zheng" <famz@redhat.com>,
"Eric Auger" <eric.auger@redhat.com>,
"John Snow" <jsnow@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [RFC v2 3/4] monitor: remove "x-oob", turn oob on by default
Date: Fri, 8 Jun 2018 14:32:26 +0800 [thread overview]
Message-ID: <20180608063226.GC7736@xz-mi> (raw)
In-Reply-To: <87efhizuxl.fsf@dusky.pond.sub.org>
On Thu, Jun 07, 2018 at 01:40:22PM +0200, Markus Armbruster wrote:
> Peter Xu <peterx@redhat.com> writes:
>
> > There was a regression reported by Eric Auger before with OOB:
> >
> > http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html
> >
> > The fix is 951702f39c ("monitor: bind dispatch bh to iohandler context",
> > 2018-04-10), which is in master already.
> >
> > For the bug, we turned Out-Of-Band feature of monitors off for 2.12
> > release. Now we turn that on again after the 2.12 release.
> >
> > This patch partly reverts be933ffc23 (monitor: new parameter "x-oob"),
> > meanwhile turn it on again by default for non-MUX QMPs.
>
> Please add a brief explanation why OOB isn't turned on for MUX. Pointer
> to existing explanation would be fine.
Sure.
--
Peter Xu
next prev parent reply other threads:[~2018-06-08 6:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 5:16 [Qemu-devel] [RFC v2 0/4] monitor: enable OOB by default Peter Xu
2018-05-31 5:16 ` [Qemu-devel] [RFC v2 1/4] docs: mention shared state protect for OOB Peter Xu
2018-05-31 14:06 ` Eric Blake
2018-06-07 8:06 ` Peter Xu
2018-05-31 5:16 ` [Qemu-devel] [RFC v2 2/4] tests: iotests: don't compare SHUTDOWN event Peter Xu
2018-05-31 14:42 ` Eric Blake
2018-06-04 4:59 ` Peter Xu
2018-06-04 8:10 ` Peter Xu
2018-05-31 5:16 ` [Qemu-devel] [RFC v2 3/4] monitor: remove "x-oob", turn oob on by default Peter Xu
2018-05-31 14:44 ` Eric Blake
2018-06-07 8:08 ` Peter Xu
2018-06-07 11:40 ` Markus Armbruster
2018-06-08 6:32 ` Peter Xu [this message]
2018-05-31 5:16 ` [Qemu-devel] [RFC v2 4/4] Revert "tests: Add parameter to qtest_init_without_qmp_handshake" Peter Xu
2018-05-31 14:51 ` Eric Blake
2018-06-07 8:13 ` Peter Xu
2018-05-31 5:20 ` [Qemu-devel] [RFC v2 0/4] monitor: enable OOB by default Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180608063226.GC7736@xz-mi \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=dgilbert@redhat.com \
--cc=eric.auger@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).