From: "Alex Bennée" <alex.bennee@linaro.org>
To: cota@braap.org, famz@redhat.com, berrange@redhat.com,
f4bug@amsat.org, richard.henderson@linaro.org, balrogg@gmail.com,
aurelien@aurel32.net, agraf@suse.de, pbonzini@redhat.com,
stefanha@redhat.com, stefanb@linux.vnet.ibm.com,
marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [Qemu-devel] [PATCH v6 48/49] tests/docker: prevent sub-makes re-building debian-sid
Date: Fri, 8 Jun 2018 13:33:06 +0100 [thread overview]
Message-ID: <20180608123307.24773-49-alex.bennee@linaro.org> (raw)
In-Reply-To: <20180608123307.24773-1-alex.bennee@linaro.org>
This is a bit of a hack but having ensured Debian SID is built at
least once in the top-level we don't need to do it over and over
again. Perhaps a better solution would be to have docker.py spit out
the dependency if a base image is too old?
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/docker/Makefile.include | 6 +++++-
tests/tcg/Makefile.include | 1 +
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index 78568d7c61..3393e9f97d 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -63,8 +63,12 @@ docker-image-debian-win64-cross: docker-image-debian8-mxe
# Debian SID images - we are tracking a rolling distro so we want to
# force a re-build of the base image if we ever need to build one of
-# its children.
+# its children. However when doing check-tcg we ensure everything is
+# built at top-level make so we can dispense with NOCACHE here to
+# avoid excessive re-builds.
+ifneq ($(SUBMAKE_NOCACHE_HACK),y)
docker-image-debian-sid: NOCACHE=1
+endif
docker-image-debian-alpha-cross: docker-image-debian-sid
docker-image-debian-hppa-cross: docker-image-debian-sid
diff --git a/tests/tcg/Makefile.include b/tests/tcg/Makefile.include
index 4851df0951..951f40c28d 100644
--- a/tests/tcg/Makefile.include
+++ b/tests/tcg/Makefile.include
@@ -39,6 +39,7 @@ ifeq ($(HAVE_USER_DOCKER)$(GUEST_BUILD),y)
ifneq ($(DOCKER_IMAGE),)
# We also need the Docker make rules to depend on
+SUBMAKE_NOCACHE_HACK=y
include $(SRC_PATH)/tests/docker/Makefile.include
DOCKER_COMPILE_CMD="$(DOCKER_SCRIPT) cc --user $(shell id -u) \
--
2.17.1
next prev parent reply other threads:[~2018-06-08 12:39 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 12:32 [Qemu-devel] [PATCH v6 00/49] fix building of tests/tcg Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 01/49] configure: add support for --cross-cc-FOO Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 02/49] configure: move i386_cc to cross_cc_i386 Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 03/49] configure: allow user to specify --cross-cc-cflags-foo= Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 04/49] configure: set cross_cc_FOO for host compiler Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 05/49] docker: Add "cc" subcommand Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 06/49] docker: extend "cc" command to accept compiler Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 07/49] docker: allow "cc" command to run in user context Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 08/49] docker: Makefile.include introduce DOCKER_SCRIPT Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 09/49] tests/tcg: move architecture independent tests into subdir Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 10/49] tests/tcg/multiarch: Build fix for linux-test Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 11/49] tests/tcg/multiarch: enable additional linux-test tests Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 12/49] tests/tcg/multiarch: move most output to stdout Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 13/49] tests/tcg: move i386 specific tests into subdir Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 14/49] tests/tcg: enable building for i386 Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 15/49] tests/tcg/i386: Build fix for hello-i386 Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 16/49] tests/tcg/i386: fix test-i386 Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 17/49] tests/tcg/i386: add runner for test-i386-fprem Alex Bennée
2018-06-11 2:22 ` Philippe Mathieu-Daudé
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 18/49] tests/tcg/x86_64: add Makefile.target Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 19/49] tests/tcg/i386/test-i386: use modern vector_size attributes Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 20/49] tests/tcg/i386/test-i386: fix printf format Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 21/49] tests/tcg: move ARM specific tests into subdir Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 22/49] tests/tcg: enable building for ARM Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 23/49] tests/tcg/arm: fix up test-arm-iwmmxt test Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 24/49] tests/tcg: enable building for AArch64 Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 25/49] tests/tcg/arm: add fcvt test cases for AArch32/64 Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 26/49] tests/tcg: move MIPS specific tests into subdir Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 27/49] tests/tcg: enable building for MIPS Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 28/49] tests/tcg/mips: include common mips hello-mips Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 29/49] tests/tcg: enable building for s390x Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 30/49] tests/tcg: enable building for ppc64 Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 31/49] tests/tcg: enable building for Alpha Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 32/49] tests/tcg/alpha: add Alpha specific tests Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 33/49] tests/tcg: enable building for HPPA Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 34/49] tests/tcg: enable building for m68k Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 35/49] tests/tcg: enable building for sh4 Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 36/49] tests/tcg: enable building for sparc64 Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 37/49] tests/tcg: enable building for mips64 Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 38/49] tests/tcg: enable building for RISCV64 Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 39/49] docker: move debian-powerpc-cross to sid based build Alex Bennée
2018-06-11 1:30 ` Philippe Mathieu-Daudé
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 40/49] tests/tcg: enable building for PowerPC Alex Bennée
2018-06-11 1:52 ` Philippe Mathieu-Daudé
2018-06-11 8:18 ` Alex Bennée
2018-06-08 12:32 ` [Qemu-devel] [PATCH v6 41/49] tests/tcg/Makefile: update to be called from Makefile.target Alex Bennée
2018-06-11 1:50 ` Philippe Mathieu-Daudé
2018-06-08 12:33 ` [Qemu-devel] [PATCH v6 42/49] Makefile.target: add (clean-/build-)guest-tests targets Alex Bennée
2018-06-11 2:15 ` Philippe Mathieu-Daudé
2018-06-08 12:33 ` [Qemu-devel] [PATCH v6 43/49] tests/Makefile.include: add [build|clean|check]-tcg targets Alex Bennée
2018-06-08 12:33 ` [Qemu-devel] [PATCH v6 44/49] tests/tcg: add run, diff, and skip helper macros Alex Bennée
2018-06-11 2:16 ` Philippe Mathieu-Daudé
2018-06-08 12:33 ` [Qemu-devel] [PATCH v6 45/49] tests/tcg: override runners for broken tests Alex Bennée
2018-06-11 1:58 ` Philippe Mathieu-Daudé
2018-06-08 12:33 ` [Qemu-devel] [PATCH v6 46/49] target/sh4: Fix translator.c assertion failure for gUSA Alex Bennée
2018-06-08 12:33 ` [Qemu-devel] [PATCH v6 47/49] tests: add top-level make dependency for docker builds Alex Bennée
2018-06-11 0:00 ` Philippe Mathieu-Daudé
2018-06-11 7:17 ` Alex Bennée
2018-06-11 1:34 ` Philippe Mathieu-Daudé
2018-06-11 7:18 ` Alex Bennée
2018-06-08 12:33 ` Alex Bennée [this message]
2018-06-08 12:33 ` [Qemu-devel] [PATCH v6 49/49] .travis.yml: add check-tcg test Alex Bennée
2018-06-11 2:09 ` Philippe Mathieu-Daudé
2018-06-11 8:21 ` Alex Bennée
2018-06-08 14:23 ` [Qemu-devel] [PATCH v6 00/49] fix building of tests/tcg no-reply
2018-06-11 2:02 ` Philippe Mathieu-Daudé
2018-06-11 8:19 ` Alex Bennée
2018-06-11 10:47 ` Philippe Mathieu-Daudé
2018-06-11 2:27 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180608123307.24773-49-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=balrogg@gmail.com \
--cc=berrange@redhat.com \
--cc=cota@braap.org \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).