From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>,
Igor Mammedov <imammedo@redhat.com>,
david@redhat.com, Thomas Huth <thuth@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>,
Greg Kurz <groug@kaod.org>
Subject: [Qemu-devel] [PATCH v2 4/6] spapr: introduce machine unplug handler
Date: Fri, 8 Jun 2018 14:48:14 +0200 [thread overview]
Message-ID: <20180608124816.22140-5-david@redhat.com> (raw)
In-Reply-To: <20180608124816.22140-1-david@redhat.com>
We'll be handling unplug of e.g. CPUs and PCDIMMs via the general
hotplug handler soon, so let's add that handler function.
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Greg Kurz <groug@kaod.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/ppc/spapr.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 9b8b4068b1..c45f8bc75b 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -3584,6 +3584,11 @@ static void spapr_machine_device_plug(HotplugHandler *hotplug_dev,
}
}
+static void spapr_machine_device_unplug(HotplugHandler *hotplug_dev,
+ DeviceState *dev, Error **errp)
+{
+}
+
static void spapr_machine_device_unplug_request(HotplugHandler *hotplug_dev,
DeviceState *dev, Error **errp)
{
@@ -3978,6 +3983,7 @@ static void spapr_machine_class_init(ObjectClass *oc, void *data)
mc->get_default_cpu_node_id = spapr_get_default_cpu_node_id;
mc->possible_cpu_arch_ids = spapr_possible_cpu_arch_ids;
hc->unplug_request = spapr_machine_device_unplug_request;
+ hc->unplug = spapr_machine_device_unplug;
smc->dr_lmb_enabled = true;
mc->default_cpu_type = POWERPC_CPU_TYPE_NAME("power8_v2.0");
--
2.17.0
next prev parent reply other threads:[~2018-06-08 12:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 12:48 [Qemu-devel] [PATCH v2 0/6] spapr: machine hotplug handler cleanups David Hildenbrand
2018-06-08 12:48 ` [Qemu-devel] [PATCH v2 1/6] spapr: no need to verify the node David Hildenbrand
2018-06-08 12:48 ` [Qemu-devel] [PATCH v2 2/6] spapr: move lookup of the node into spapr_memory_plug() David Hildenbrand
2018-06-08 13:20 ` Greg Kurz
2018-06-08 12:48 ` [Qemu-devel] [PATCH v2 3/6] spapr: move memory hotplug support check into spapr_memory_pre_plug() David Hildenbrand
2018-06-08 13:36 ` Greg Kurz
2018-06-08 12:48 ` David Hildenbrand [this message]
2018-06-08 12:48 ` [Qemu-devel] [PATCH v2 5/6] spapr: handle pc-dimm unplug via hotplug handler chain David Hildenbrand
2018-06-08 12:48 ` [Qemu-devel] [PATCH v2 6/6] spapr: handle cpu core " David Hildenbrand
2018-06-09 2:01 ` [Qemu-devel] [PATCH v2 0/6] spapr: machine hotplug handler cleanups David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180608124816.22140-5-david@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).