From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, armbru@redhat.com, imammedo@redhat.com
Subject: [Qemu-devel] [PATCH v3 3/7] hmp: Restrict auto-complete in preconfig
Date: Fri, 8 Jun 2018 14:08:42 +0100 [thread overview]
Message-ID: <20180608130846.22234-4-dgilbert@redhat.com> (raw)
In-Reply-To: <20180608130846.22234-1-dgilbert@redhat.com>
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Don't show the commands that aren't available.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
---
monitor.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/monitor.c b/monitor.c
index 31c8f5dc88..c369b392db 100644
--- a/monitor.c
+++ b/monitor.c
@@ -3951,12 +3951,17 @@ static void monitor_find_completion_by_table(Monitor *mon,
cmdname = args[0];
readline_set_completion_index(mon->rs, strlen(cmdname));
for (cmd = cmd_table; cmd->name != NULL; cmd++) {
- cmd_completion(mon, cmdname, cmd->name);
+ if (!runstate_check(RUN_STATE_PRECONFIG) ||
+ cmd_can_preconfig(cmd)) {
+ cmd_completion(mon, cmdname, cmd->name);
+ }
}
} else {
/* find the command */
for (cmd = cmd_table; cmd->name != NULL; cmd++) {
- if (compare_cmd(args[0], cmd->name)) {
+ if (compare_cmd(args[0], cmd->name) &&
+ (!runstate_check(RUN_STATE_PRECONFIG) ||
+ cmd_can_preconfig(cmd))) {
break;
}
}
--
2.17.0
next prev parent reply other threads:[~2018-06-08 13:08 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 13:08 [Qemu-devel] [PATCH v3 0/7] Reenable hmp for preconfig mode Dr. David Alan Gilbert (git)
2018-06-08 13:08 ` [Qemu-devel] [PATCH v3 1/7] hmp: Add flag for preconfig commands Dr. David Alan Gilbert (git)
2018-06-11 8:49 ` Markus Armbruster
2018-06-11 17:37 ` Dr. David Alan Gilbert
2018-06-08 13:08 ` [Qemu-devel] [PATCH v3 2/7] hmp: Allow help on " Dr. David Alan Gilbert (git)
2018-06-11 9:00 ` Markus Armbruster
2018-06-11 10:27 ` Dr. David Alan Gilbert
2018-06-11 13:18 ` Markus Armbruster
2018-06-11 18:49 ` Dr. David Alan Gilbert
2018-06-12 7:03 ` Markus Armbruster
2018-06-08 13:08 ` Dr. David Alan Gilbert (git) [this message]
2018-06-11 9:02 ` [Qemu-devel] [PATCH v3 3/7] hmp: Restrict auto-complete in preconfig Markus Armbruster
2018-06-11 17:38 ` Dr. David Alan Gilbert
2018-06-08 13:08 ` [Qemu-devel] [PATCH v3 4/7] qmp: enable query-[chardev|version|name|uuid|iothreads|memdev] commands in preconfig state Dr. David Alan Gilbert (git)
2018-06-11 11:28 ` Markus Armbruster
2018-06-11 17:43 ` Dr. David Alan Gilbert
2018-06-12 7:05 ` Markus Armbruster
2018-06-08 13:08 ` [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig Dr. David Alan Gilbert (git)
2018-06-11 12:01 ` Markus Armbruster
2018-06-11 17:49 ` Dr. David Alan Gilbert
2018-06-12 5:37 ` Gerd Hoffmann
2018-06-12 12:00 ` Markus Armbruster
2018-06-12 12:52 ` Dr. David Alan Gilbert
2018-06-15 16:10 ` [Qemu-devel] Abandon our QMP first policy? (was: [PATCH v3 5/7] hmp: Add info commands for preconfig) Markus Armbruster
2018-06-15 16:32 ` Dr. David Alan Gilbert
2018-06-15 18:44 ` Eduardo Habkost
2018-06-18 6:36 ` Gerd Hoffmann
2018-06-20 14:48 ` Dr. David Alan Gilbert
2018-06-12 6:43 ` [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig Markus Armbruster
2018-06-12 8:49 ` Dr. David Alan Gilbert
2018-06-13 13:47 ` Eduardo Habkost
2018-06-13 13:53 ` Daniel P. Berrangé
2018-06-13 16:59 ` Eduardo Habkost
2018-06-11 18:40 ` Eduardo Habkost
2018-06-11 21:33 ` Igor Mammedov
2018-06-12 7:00 ` Markus Armbruster
2018-06-13 13:44 ` Eduardo Habkost
2018-06-12 7:57 ` Daniel P. Berrangé
2018-06-08 13:08 ` [Qemu-devel] [PATCH v3 6/7] hmp: add exit_preconfig Dr. David Alan Gilbert (git)
2018-06-11 12:04 ` Markus Armbruster
2018-06-11 18:29 ` Dr. David Alan Gilbert
2018-06-08 13:08 ` [Qemu-devel] [PATCH v3 7/7] hmp: Allow HMP in preconfig state again Dr. David Alan Gilbert (git)
2018-06-11 12:06 ` [Qemu-devel] [PATCH v3 0/7] Reenable hmp for preconfig mode Markus Armbruster
2018-06-11 12:09 ` Dr. David Alan Gilbert
2018-06-11 12:44 ` Markus Armbruster
2018-06-14 13:17 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180608130846.22234-4-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).