qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	linux-nvdimm <linux-nvdimm@lists.01.org>,
	Qemu Developers <qemu-devel@nongnu.org>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Dan Williams <dan.j.williams@intel.com>
Subject: Re: [Qemu-devel] [qemu PATCH 4/5] machine: fix some misspelled words
Date: Fri, 8 Jun 2018 11:41:14 -0600	[thread overview]
Message-ID: <20180608174114.GA30678@linux.intel.com> (raw)
In-Reply-To: <17f8856c-48d9-d112-cd7f-e1b3679d2f43@redhat.com>

On Fri, Jun 08, 2018 at 07:38:17AM +0200, Thomas Huth wrote:
> On 08.06.2018 00:31, Ross Zwisler wrote:
> > Normally this might not be worth fixing, but several of these are strings
> > which are displayed to users.
> > 
> > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> > ---
> >  hw/core/machine.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/hw/core/machine.c b/hw/core/machine.c
> > index 617e5f8d75..a21269fa39 100644
> > --- a/hw/core/machine.c
> > +++ b/hw/core/machine.c
> > @@ -609,7 +609,7 @@ static void machine_class_init(ObjectClass *oc, void *data)
> >          machine_get_igd_gfx_passthru, machine_set_igd_gfx_passthru,
> >          &error_abort);
> >      object_class_property_set_description(oc, "igd-passthru",
> > -        "Set on/off to enable/disable igd passthrou", &error_abort);
> > +        "Set on/off to enable/disable igd passthru", &error_abort);
> 
> Shouldn't that rather be "passthrough" instead?

Either works, I think.  "thru" and "passthru" are short informal versions of
"through" and "passthrough", but both the long and short versions of both
words are used all over the QEMU source.  "passthrou" is clearly wrong.  If
the longer version is preferred in this case please feel free to fix up when
you apply.

  reply	other threads:[~2018-06-08 17:41 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-07 22:31 [Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job files Ross Zwisler
2018-06-07 22:31 ` [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch Ross Zwisler
2018-06-07 23:09   ` Michael S. Tsirkin
2018-06-08  5:17     ` Thomas Huth
2018-06-08 15:34       ` Ross Zwisler
2018-06-08 15:59         ` Michael S. Tsirkin
2018-06-08 16:14           ` Peter Maydell
2018-06-08 16:21             ` Michael S. Tsirkin
2018-06-08 16:03       ` Michael S. Tsirkin
2018-06-08 16:16         ` Peter Maydell
2018-06-08 16:24           ` Michael S. Tsirkin
2018-06-08 17:23             ` Thomas Huth
2018-06-08 18:41               ` Michael S. Tsirkin
2018-06-08 19:56                 ` Thomas Huth
2018-06-07 22:31 ` [Qemu-devel] [qemu PATCH 3/5] hw/i386: Update SSDT table used by "make check" Ross Zwisler
2018-06-07 23:14   ` Michael S. Tsirkin
2018-06-08 14:24     ` Eric Blake
2018-06-08 16:00       ` Michael S. Tsirkin
2018-06-08  5:39   ` Thomas Huth
2018-06-07 22:31 ` [Qemu-devel] [qemu PATCH 4/5] machine: fix some misspelled words Ross Zwisler
2018-06-08  5:38   ` Thomas Huth
2018-06-08 17:41     ` Ross Zwisler [this message]
2018-06-08 18:01       ` Eric Blake
2018-06-07 22:31 ` [Qemu-devel] [qemu PATCH 5/5] nvdimm: make persistence option symbolic Ross Zwisler
2018-06-08 19:34   ` Michael S. Tsirkin
2018-06-08 14:59 ` [Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job files Eric Blake
2018-06-08 15:00   ` Eric Blake
2018-06-08 15:36   ` Ross Zwisler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180608174114.GA30678@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=linux-nvdimm@lists.01.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).