From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: mreitz@redhat.com, kwolf@redhat.com, stefanha@gmail.com,
	pl@kamp.de, vsementsov@virtuozzo.com, den@openvz.org
Subject: [Qemu-devel] [PATCH 1/3] qemu-img: allow compressed not-in-order writes
Date: Fri,  8 Jun 2018 22:20:25 +0300	[thread overview]
Message-ID: <20180608192027.284601-2-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20180608192027.284601-1-vsementsov@virtuozzo.com>
No reason to forbid them, and they are needed to improve performance
with compress-threads in further patches.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 qemu-img.c | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 75f1610aa0..df2657b9cb 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -2122,11 +2122,6 @@ static int img_convert(int argc, char **argv)
         goto fail_getopt;
     }
 
-    if (!s.wr_in_order && s.compressed) {
-        error_report("Out of order write and compress are mutually exclusive");
-        goto fail_getopt;
-    }
-
     if (tgt_image_opts && !skip_create) {
         error_report("--target-image-opts requires use of -n flag");
         goto fail_getopt;
-- 
2.11.1
next prev parent reply	other threads:[~2018-06-08 19:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-08 19:20 [Qemu-devel] [PATCH 0/3] qcow2 compress threads Vladimir Sementsov-Ogievskiy
2018-06-08 19:20 ` Vladimir Sementsov-Ogievskiy [this message]
2018-06-08 19:20 ` [Qemu-devel] [PATCH 2/3] qcow2: refactor data compression Vladimir Sementsov-Ogievskiy
2018-06-14 13:06   ` Kevin Wolf
2018-06-08 19:20 ` [Qemu-devel] [PATCH 3/3] qcow2: add compress threads Vladimir Sementsov-Ogievskiy
2018-06-14 13:16   ` Kevin Wolf
2018-06-14 13:19     ` Denis V. Lunev
2018-06-14 13:29       ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=20180608192027.284601-2-vsementsov@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).