qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, quintela@redhat.com
Subject: [Qemu-devel] [PATCH] migration: invalidate cache before source start
Date: Sat,  9 Jun 2018 17:14:57 +0300	[thread overview]
Message-ID: <20180609141457.6283-1-vsementsov@virtuozzo.com> (raw)

Invalidate cache before source start in case of failed migration.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---

 migration/migration.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/migration/migration.c b/migration/migration.c
index 1e99ec9b7e..8f39e0dc02 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2806,7 +2806,14 @@ static void migration_iteration_finish(MigrationState *s)
     case MIGRATION_STATUS_FAILED:
     case MIGRATION_STATUS_CANCELLED:
         if (s->vm_was_running) {
-            vm_start();
+            Error *local_err = NULL;
+            bdrv_invalidate_cache_all(&local_err);
+            if (local_err) {
+                error_reportf_err(local_err, "Can't invalidate disks before "
+                                  "source vm start");
+            } else {
+                vm_start();
+            }
         } else {
             if (runstate_check(RUN_STATE_FINISH_MIGRATE)) {
                 runstate_set(RUN_STATE_POSTMIGRATE);
-- 
2.11.1

             reply	other threads:[~2018-06-09 15:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-09 14:14 Vladimir Sementsov-Ogievskiy [this message]
2018-06-15 12:06 ` [Qemu-devel] [PATCH] migration: invalidate cache before source start Dr. David Alan Gilbert
2018-06-15 12:33   ` Vladimir Sementsov-Ogievskiy
2018-06-22 20:54     ` John Snow
2018-06-25 17:14     ` Dr. David Alan Gilbert
2018-06-25 17:50       ` Dr. David Alan Gilbert
2018-06-25 18:03         ` John Snow
2018-06-26  7:31           ` Vladimir Sementsov-Ogievskiy
2018-06-26 19:11             ` Dr. David Alan Gilbert
2018-06-26  8:44         ` Vladimir Sementsov-Ogievskiy
2018-10-08 15:36           ` Vladimir Sementsov-Ogievskiy
2018-10-08 20:21             ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180609141457.6283-1-vsementsov@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).