From: Peter Xu <peterx@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v10 5/7] monitor: remove event_clock_type
Date: Mon, 11 Jun 2018 10:42:01 +0800 [thread overview]
Message-ID: <20180611024201.GH7736@xz-mi> (raw)
In-Reply-To: <87vaat4uuy.fsf@dusky.pond.sub.org>
On Fri, Jun 08, 2018 at 09:09:57AM +0200, Markus Armbruster wrote:
> Peter Xu <peterx@redhat.com> writes:
>
> > On Fri, Jun 08, 2018 at 07:38:11AM +0200, Markus Armbruster wrote:
> >
> > [...]
> >
> >> > +/*
> >> > + * This should never be called before configure_accelerator() since
> >> > + * only until then could we know whether qtest was enabled or not.
> >>
> >> Uh, we know it after then, not until then. What about
> >>
> >> /*
> >> * Return the clock to use for recording an event's time.
> >> * Beware: result is invalid before configure_accelerator().
> >
> > Oh, another Chinglish from me. :(
>
> Useful code, occasional Chinglish, the humility to go with it, and a
> sense of humor --- you're doing fine.
Very high evaluation. Thank you. :)
--
Peter Xu
next prev parent reply other threads:[~2018-06-11 2:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 3:55 [Qemu-devel] [PATCH v10 0/7] monitor: let Monitor be thread safe Peter Xu
2018-06-08 3:55 ` [Qemu-devel] [PATCH v10 1/7] monitor: rename out_lock to mon_lock Peter Xu
2018-06-08 3:55 ` [Qemu-devel] [PATCH v10 2/7] monitor: protect mon->fds with mon_lock Peter Xu
2018-06-08 3:55 ` [Qemu-devel] [PATCH v10 3/7] monitor: more comments on lock-free elements Peter Xu
2018-06-08 3:55 ` [Qemu-devel] [PATCH v10 4/7] monitor: fix comment for monitor_lock Peter Xu
2018-06-08 3:55 ` [Qemu-devel] [PATCH v10 5/7] monitor: remove event_clock_type Peter Xu
2018-06-08 5:38 ` Markus Armbruster
2018-06-08 6:24 ` Peter Xu
2018-06-08 7:09 ` Markus Armbruster
2018-06-11 2:42 ` Peter Xu [this message]
2018-06-08 13:31 ` Stefan Hajnoczi
2018-06-08 3:55 ` [Qemu-devel] [PATCH v10 6/7] monitor: move init global earlier Peter Xu
2018-06-08 3:55 ` [Qemu-devel] [PATCH v10 7/7] monitor: add lock to protect mon_fdsets Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611024201.GH7736@xz-mi \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).