From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSOGi-0003km-22 for qemu-devel@nongnu.org; Mon, 11 Jun 2018 10:58:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSOGe-0000fV-Vn for qemu-devel@nongnu.org; Mon, 11 Jun 2018 10:58:04 -0400 Date: Mon, 11 Jun 2018 16:57:55 +0200 From: Cornelia Huck Message-ID: <20180611165755.64b684c8.cohuck@redhat.com> In-Reply-To: <20180611141716.3813-1-peter.maydell@linaro.org> References: <20180611141716.3813-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, patches@linaro.org, Richard Henderson , John Snow , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , Alex Williamson , Thomas Huth , Markus Armbruster , Stefan Hajnoczi , Kevin Wolf On Mon, 11 Jun 2018 15:17:16 +0100 Peter Maydell wrote: > The codebase has a bit of a mix of different multiline > comment styles. State a preference for the Linux kernel > style: > /* > * Star on the left for each line. > * Leading slash-star and trailing star-slash > * each go on a line of their own. > */ > > Signed-off-by: Peter Maydell > --- > This is not my personal favourite, but seemed to be the > closest we had to consensus in the mail thread for v1; > I can live with it in order to avoid getting patches which > use the styles I like even less :-) > --- > CODING_STYLE | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) Reviewed-by: Cornelia Huck