From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33838) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSQxG-0008E6-HY for qemu-devel@nongnu.org; Mon, 11 Jun 2018 13:50:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSQxC-0002Za-FY for qemu-devel@nongnu.org; Mon, 11 Jun 2018 13:50:10 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:44140 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fSQxC-0002ZJ-A8 for qemu-devel@nongnu.org; Mon, 11 Jun 2018 13:50:06 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A87DC401EF00 for ; Mon, 11 Jun 2018 17:50:05 +0000 (UTC) Date: Mon, 11 Jun 2018 18:49:58 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20180611174958.GP2661@work-vm> References: <20180608130846.22234-1-dgilbert@redhat.com> <20180608130846.22234-6-dgilbert@redhat.com> <87y3flilan.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y3flilan.fsf@dusky.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, imammedo@redhat.com, Gerd Hoffmann , Eduardo Habkost * Markus Armbruster (armbru@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" writes: > > > From: "Dr. David Alan Gilbert" > > > > Allow a bunch of the info commands to be used in preconfig. > > > > version, chardev, name, uuid,memdev, iothreads > > Were enabled in QMP in the previous patch from Igor > > Yes, these are okay together with PATCH 4. > > > status, hotpluggable_cpus > > Was enabled in the original allow-preconfig series > > query-status looks okay to me. > > > history > > is HMP specific > > Yes. > > > usbhost, qom-tree, numa > > Don't have a QMP equivalent > > HMP commands without a QMP equivalent are okay if their functionality > makes no sense in QMP, or is of use only for human users. > > Example for "makes no sense in QMP": setting the current CPU, because a > QMP monitor doesn't have a current CPU. > > Examples for "is of use only for human users": HMP command "help", the > integrated pocket calculator. Right, but they do already exist; it's possible we may want to fix/add QMP versions - but this series isn't about going through and fixing existing stuff up. > Now let's review the three commands: > > * Gerd, why does "info usbhost" have no QMP equivalent? > > * Eduardo, why does "info numa" have no QMP equivalent? > > * "info qom-tree" is a recursive variant of qom-list that skips anything > but children. This convenience command exists so you don't have to > filter and string together output from many qom-list. > > I think it stands to reason that if providing "info qom-tree" makes > sense, then so does qom-list (HMP and QMP). If qom-list, then > qom-list-types, qom-list-properties, qom-get, and probably even > qom-set (I've always been suspicious of qom-set, but that has nothing > to do with preconfig state). > > It might make sense to split off the whole QOM shebang into a separate > patch. People have been trying to add qom-get etc for quite a while (I tried a couple of years ago); it gets stuck in type display issues. I've not directly seen a need for those other variants, but qom-get is something I'd love to have, still that's a job for another patch. 'info qom-tree' is very very useful when debugging qemu to see what the basic state we're building is; it's primarily for debugging. Dave > > Signed-off-by: Dr. David Alan Gilbert -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK