From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSU0C-0004Pe-Lb for qemu-devel@nongnu.org; Mon, 11 Jun 2018 17:05:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSU09-00085x-Fu for qemu-devel@nongnu.org; Mon, 11 Jun 2018 17:05:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54368) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fSU09-000859-9F for qemu-devel@nongnu.org; Mon, 11 Jun 2018 17:05:21 -0400 Date: Mon, 11 Jun 2018 18:05:15 -0300 From: Eduardo Habkost Message-ID: <20180611210515.GZ7451@localhost.localdomain> References: <1528498581-131037-1-git-send-email-babu.moger@amd.com> <1528498581-131037-3-git-send-email-babu.moger@amd.com> <20180611204623.GV7451@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180611204623.GV7451@localhost.localdomain> Subject: Re: [Qemu-devel] [PATCH v13 2/5] i386: Introduce auto_topoext bit to manage topoext List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Moger, Babu" Cc: "mst@redhat.com" , "marcel.apfelbaum@gmail.com" , "pbonzini@redhat.com" , "rth@twiddle.net" , "mtosatti@redhat.com" , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , "kash@tripleback.net" , "geoff@hostfission.com" On Mon, Jun 11, 2018 at 05:46:23PM -0300, Eduardo Habkost wrote: [...] > On PC_COMPAT_2_12, both would work: > { TYPE_X86_CPU, "auto-topoext", "off" } > or > { "EPYC" "-" TYPE_X86_CPU, "auto-topoext", "off" }. > > I prefer the latter, but both would work. Oh, while we're at it: please name the property "x-auto-topoext", to indicate it's only for QEMU internal use or debugging, and not a supported command-line option. -- Eduardo