qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: laurent@vivier.eu, peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH v3 05/19] linux-user: Remove DEBUG
Date: Mon, 11 Jun 2018 14:51:31 -1000	[thread overview]
Message-ID: <20180612005145.3375-6-richard.henderson@linaro.org> (raw)
In-Reply-To: <20180612005145.3375-1-richard.henderson@linaro.org>

This is redundant with both -strace and actual tracing.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 linux-user/syscall.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 7b9ac3b408..c212149245 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -163,7 +163,6 @@
  * (The one remaining unallocated bit is 0x1000 which used to be CLONE_PID.)
  */
 
-//#define DEBUG
 /* Define DEBUG_ERESTARTSYS to force every syscall to be restarted
  * once. This exercises the codepaths for restart.
  */
@@ -5777,9 +5776,6 @@ static abi_long do_ioctl(int fd, int cmd, abi_long arg)
         ie++;
     }
     arg_type = ie->arg_type;
-#if defined(DEBUG)
-    gemu_log("ioctl: cmd=0x%04lx (%s)\n", (long)cmd, ie->name);
-#endif
     if (ie->do_ioctl) {
         return ie->do_ioctl(ie, buf_temp, fd, cmd, arg);
     } else if (!ie->host_cmd) {
@@ -7980,9 +7976,6 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
     }
 #endif
 
-#ifdef DEBUG
-    gemu_log("syscall %d", num);
-#endif
     trace_guest_user_syscall(cpu, num, arg1, arg2, arg3, arg4, arg5, arg6, arg7, arg8);
     if(do_strace)
         print_syscall(num, arg1, arg2, arg3, arg4, arg5, arg6);
@@ -12772,9 +12765,6 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
         break;
     }
 fail:
-#ifdef DEBUG
-    gemu_log(" = " TARGET_ABI_FMT_ld "\n", ret);
-#endif
     if(do_strace)
         print_syscall_ret(num, ret);
     trace_guest_user_syscall_ret(cpu, num, ret);
-- 
2.17.1

  parent reply	other threads:[~2018-06-12  0:52 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12  0:51 [Qemu-devel] [PATCH v3 00/19] linux-user: Split do_syscall Richard Henderson
2018-06-12  0:51 ` [Qemu-devel] [PATCH v3 01/19] linux-user/alpha: Fix epoll syscalls Richard Henderson
2018-06-12  0:51 ` [Qemu-devel] [PATCH v3 02/19] linux-user/hppa: Fix typo in mknodat syscall Richard Henderson
2018-06-12  0:51 ` [Qemu-devel] [PATCH v3 03/19] linux-user/microblaze: Fix typo in accept4 syscall Richard Henderson
2018-06-12  0:51 ` [Qemu-devel] [PATCH v3 04/19] linux-user/sparc64: Add inotify_rm_watch and tee syscalls Richard Henderson
2018-06-12  0:51 ` Richard Henderson [this message]
2018-06-12  0:51 ` [Qemu-devel] [PATCH v3 06/19] linux-user: Split out do_syscall1 Richard Henderson
2018-06-12 16:11   ` Philippe Mathieu-Daudé
2018-06-12  0:51 ` [Qemu-devel] [PATCH v3 07/19] linux-user: Relax single exit from "break" Richard Henderson
2018-06-12 16:23   ` Philippe Mathieu-Daudé
2018-08-11 21:50   ` Laurent Vivier
2018-06-12  0:51 ` [Qemu-devel] [PATCH v3 08/19] linux-user: Propagate goto efault to return Richard Henderson
2018-06-12 16:27   ` Philippe Mathieu-Daudé
2018-06-12  0:51 ` [Qemu-devel] [PATCH v3 09/19] linux-user: Propagate goto unimplemented_nowarn " Richard Henderson
2018-06-12 16:28   ` Philippe Mathieu-Daudé
2018-06-12  0:51 ` [Qemu-devel] [PATCH v3 10/19] linux-user: Propagate goto unimplemented to default Richard Henderson
2018-06-22 10:16   ` Peter Maydell
2018-06-12  0:51 ` [Qemu-devel] [PATCH v3 11/19] linux-user: Propagate goto fail to return Richard Henderson
2018-06-12  0:51 ` [Qemu-devel] [PATCH v3 12/19] linux-user: Setup split syscall infrastructure Richard Henderson
2018-06-22 10:30   ` Peter Maydell
2018-06-22 17:32     ` Richard Henderson
2018-08-12 20:45   ` Laurent Vivier
2018-08-13  0:09     ` Richard Henderson
2018-06-12  0:51 ` [Qemu-devel] [PATCH v3 13/19] linux-user: Split out close, open, openat, read, write Richard Henderson
2018-06-22 10:38   ` Peter Maydell
2018-06-22 17:39     ` Richard Henderson
2018-06-12  0:51 ` [Qemu-devel] [PATCH v3 14/19] linux-user: Split out preadv, pwritev, readv, writev Richard Henderson
2018-06-12  0:51 ` [Qemu-devel] [PATCH v3 15/19] linux-user: Split out pread64, pwrite64 Richard Henderson
2018-06-12 16:37   ` Philippe Mathieu-Daudé
2018-06-12 17:44     ` Richard Henderson
2018-06-12 19:02       ` Philippe Mathieu-Daudé
2018-06-12  0:51 ` [Qemu-devel] [PATCH v3 16/19] linux-user: Split out name_to_handle_at, open_by_handle_at Richard Henderson
2018-06-12  0:51 ` [Qemu-devel] [PATCH v3 17/19] linux-user: Split out ipc syscalls Richard Henderson
2018-06-12  0:51 ` [Qemu-devel] [PATCH v3 18/19] linux-user: Split out memory syscalls Richard Henderson
2018-06-12  0:51 ` [Qemu-devel] [PATCH v3 19/19] linux-user: Split out some process syscalls Richard Henderson
2018-08-11 22:48   ` Laurent Vivier
2018-06-12  1:19 ` [Qemu-devel] [PATCH v3 00/19] linux-user: Split do_syscall no-reply
2018-06-12 11:00 ` Laurent Vivier
2018-06-22 10:40 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180612005145.3375-6-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=laurent@vivier.eu \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).