qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: linzhecheng <linzhecheng@huawei.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com, jasowang@redhat.com, wangxinxin.wang@huawei.com,
	liujunjie23@huawei.com, linzhecheng <linzhecheng@huawei.com>
Subject: [Qemu-devel] [PATCH v2] vhost-user: delete net client if necessary
Date: Tue, 12 Jun 2018 10:24:45 +0800	[thread overview]
Message-ID: <20180612022445.5192-1-linzhecheng@huawei.com> (raw)

As qemu_new_net_client create new ncs but error happens later,
ncs will be left in global net_clients list and we can't use them any
more, so we need to cleanup them.

Signed-off-by: linzhecheng <linzhecheng@huawei.com>

diff --git a/net/vhost-user.c b/net/vhost-user.c
index 608b837175..a39f9c9974 100644
--- a/net/vhost-user.c
+++ b/net/vhost-user.c
@@ -345,6 +345,9 @@ err:
             s->vhost_user = NULL;
         }
     }
+    if (nc0) {
+        qemu_del_net_client(nc0);
+    }
 
     return -1;
 }
-- 
2.12.2.windows.2

             reply	other threads:[~2018-06-12  2:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12  2:24 linzhecheng [this message]
2018-06-15  2:35 ` [Qemu-devel] [PATCH v2] vhost-user: delete net client if necessary Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180612022445.5192-1-linzhecheng@huawei.com \
    --to=linzhecheng@huawei.com \
    --cc=jasowang@redhat.com \
    --cc=liujunjie23@huawei.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wangxinxin.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).