qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [RFC untested PATCH] i386/cpu: make -cpu host support monitor/mwait
Date: Tue, 12 Jun 2018 11:49:22 -0300	[thread overview]
Message-ID: <20180612144922.GJ7451@localhost.localdomain> (raw)
In-Reply-To: <20180612155803.4ca0d137@redhat.com>

On Tue, Jun 12, 2018 at 03:58:03PM +0200, Igor Mammedov wrote:
[...]
> > > > +    if (xcc->host_cpuid_required && enable_cpu_pm) {
> > > > +        host_cpuid(5, 0, &cpu->mwait.eax, &cpu->mwait.ebx,
> > > > +                   &cpu->mwait.ecx, &cpu->mwait.edx);
> > > > +    }  
> > > could this state be migrated? or 'host' is still unmigratable?  
> > 
> > Host is still unmigratable.
> 'max' cpu model has 'migratable = true' property and 'host' is inherited from it,
> hence was the question.

Host can be migratable if and only if the source and destination
CPUs + kernel + QEMU are exactly the same.  Not something I would
recommend to anyone, but still something we try not to break.

> 
> > 
> > > also max_x86_cpu_initfn() might be better place for filling it up.

Why?


-- 
Eduardo

  reply	other threads:[~2018-06-12 14:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-08 20:59 [Qemu-devel] [RFC untested PATCH] i386/cpu: make -cpu host support monitor/mwait Michael S. Tsirkin
2018-06-08 21:22 ` no-reply
2018-06-08 23:12 ` no-reply
2018-06-11 21:52 ` Eduardo Habkost
2018-06-12 12:56 ` Igor Mammedov
2018-06-12 12:57   ` Michael S. Tsirkin
2018-06-12 13:58     ` Igor Mammedov
2018-06-12 14:49       ` Eduardo Habkost [this message]
2018-06-13  8:55         ` Igor Mammedov
2018-06-13 18:22           ` Michael S. Tsirkin
2018-06-13 18:32             ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180612144922.GJ7451@localhost.localdomain \
    --to=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).