From: Eduardo Habkost <ehabkost@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name
Date: Tue, 12 Jun 2018 12:01:53 -0300 [thread overview]
Message-ID: <20180612150153.GK7451@localhost.localdomain> (raw)
In-Reply-To: <a8426bf6-7531-6306-d1c6-bb4c6c2099cd@redhat.com>
On Tue, Jun 12, 2018 at 08:55:55AM +0200, Paolo Bonzini wrote:
> On 11/06/2018 22:37, Eduardo Habkost wrote:
> > RFC NOTE: Paolo, Richard, as far as I can see, there's no point
> > in enabling OSPKE in user-mode QEMU. Do you confirm that?
> >
> > OSPKE is not a static feature flag: it changes dynamically at
> > runtime depending on CR4, and it was never configurable: KVM
> > never returned OSPKE on GET_SUPPORTED_CPUID, and on TCG enables
> > it automatically if CR4_PKE_MASK is set.
> >
> > Remove OSPKE from the feature name array so users don't try to
> > configure it manually.
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>
> Yes, it's the same as OSXSAVE. Thanks!
CR4_OSXSAVE_MASK is automatically enabled on user-mode QEMU,
though.
My question is if it would make any sense to enable CR4_PKE_MASK
too.
--
Eduardo
next prev parent reply other threads:[~2018-06-12 15:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 20:37 [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name Eduardo Habkost
2018-06-11 21:49 ` Richard Henderson
2018-06-12 6:55 ` Paolo Bonzini
2018-06-12 15:01 ` Eduardo Habkost [this message]
2018-06-12 15:12 ` Paolo Bonzini
2018-06-12 18:25 ` Eduardo Habkost
2018-06-13 17:01 ` Paolo Bonzini
2018-06-13 17:16 ` Eduardo Habkost
2018-06-13 17:26 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180612150153.GK7451@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).