qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: Eric Blake <eblake@redhat.com>,
	Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH v2 08/10] qcow2/bitmap: track extra_data_size
Date: Tue, 12 Jun 2018 22:06:11 -0400	[thread overview]
Message-ID: <20180613020613.1343-9-jsnow@redhat.com> (raw)
In-Reply-To: <20180613020613.1343-1-jsnow@redhat.com>

Similarly to the last patch, track the extra_data_size field that we read.
We do reject anything other than zero, but if this restriction is lifted
in the future, we'll need to update the _info field, so loosen this now.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 block/qcow2-bitmap.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c
index 36573f7b52..3c2e974458 100644
--- a/block/qcow2-bitmap.c
+++ b/block/qcow2-bitmap.c
@@ -86,6 +86,7 @@ typedef struct Qcow2Bitmap {
     uint8_t type;
     uint8_t granularity_bits;
     char *name;
+    uint32_t extra_data_size;
 
     BdrvDirtyBitmap *dirty_bitmap;
 
@@ -609,6 +610,7 @@ static Qcow2BitmapList *bitmap_list_load(BlockDriverState *bs, Error **errp)
         bm->table.size = e->bitmap_table_size;
         bm->flags = e->flags;
         bm->type = e->type;
+        bm->extra_data_size = e->extra_data_size;
         bm->granularity_bits = e->granularity_bits;
         bm->name = dir_entry_copy_name(e);
         QSIMPLEQ_INSERT_TAIL(bm_list, bm, entry);
@@ -782,7 +784,7 @@ static int bitmap_list_store(BlockDriverState *bs, Qcow2BitmapList *bm_list,
         e->type = bm->type;
         e->granularity_bits = bm->granularity_bits;
         e->name_size = strlen(bm->name);
-        e->extra_data_size = 0;
+        e->extra_data_size = bm->extra_data_size;
         memcpy(e + 1, bm->name, e->name_size);
 
         if (check_dir_entry(bs, e) < 0) {
-- 
2.14.3

  parent reply	other threads:[~2018-06-13  2:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-13  2:06 [Qemu-devel] [PATCH v2 00/10] qemu-img: add bitmap info output John Snow
2018-06-13  2:06 ` [Qemu-devel] [PATCH v2 01/10] qcow2/bitmap: remove redundant arguments from bitmap_list_load John Snow
2018-06-20  9:45   ` Vladimir Sementsov-Ogievskiy
2018-06-13  2:06 ` [Qemu-devel] [PATCH v2 02/10] qcow2/bitmap: avoid adjusting bm->flags for RO bitmaps John Snow
2018-06-20 10:01   ` Vladimir Sementsov-Ogievskiy
2018-06-13  2:06 ` [Qemu-devel] [PATCH v2 03/10] qcow2/bitmap: cache bm_list John Snow
2018-06-20 13:04   ` Vladimir Sementsov-Ogievskiy
2018-06-20 13:12     ` Vladimir Sementsov-Ogievskiy
2018-06-20 23:29     ` John Snow
2018-06-21 10:25       ` Vladimir Sementsov-Ogievskiy
2018-06-21 21:22         ` John Snow
2018-06-13  2:06 ` [Qemu-devel] [PATCH v2 04/10] qcow2/bitmap: cache loaded bitmaps John Snow
2018-06-20 13:05   ` Vladimir Sementsov-Ogievskiy
2018-06-13  2:06 ` [Qemu-devel] [PATCH v2 05/10] qcow2/bitmap: reject IN_USE bitmaps on rw reload John Snow
2018-06-13  2:06 ` [Qemu-devel] [PATCH v2 06/10] qcow2/bitmap: load IN_USE bitmaps if disk is RO John Snow
2018-06-13  2:06 ` [Qemu-devel] [PATCH v2 07/10] qcow2/bitmap: track bitmap type John Snow
2018-06-13  2:06 ` John Snow [this message]
2018-06-13  2:06 ` [Qemu-devel] [PATCH v2 09/10] qapi: add bitmap info John Snow
2018-06-13  2:06 ` [Qemu-devel] [PATCH v2 10/10] qcow2/bitmap: add basic bitmaps info John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180613020613.1343-9-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).