From: "Emilio G. Cota" <cota@braap.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 1/2] cpu-defs.h: Document CPUIOTLBEntry 'addr' field
Date: Tue, 12 Jun 2018 23:33:53 -0400 [thread overview]
Message-ID: <20180613033353.GA25430@flamenco> (raw)
In-Reply-To: <20180611125633.32755-2-peter.maydell@linaro.org>
On Mon, Jun 11, 2018 at 13:56:32 +0100, Peter Maydell wrote:
> typedef struct CPUIOTLBEntry {
> + /*
> + * @addr contains:
> + * - in the lower TARGET_PAGE_BITS, a physical section number
> + * - with the lower TARGET_PAGE_BITS masked off, an offset which
> + * must be added to the virtual address to obtain:
> + * + the ramaddr_t of the target RAM (if the physical section
s/ramaddr_t/ram_addr_t/ ? Also in cputlb.c:
> + * TARGET_PAGE_BITS, and either
> + * + the ramaddr_t of the page base of the target RAM (if NOTDIRTY or ROM)
Thanks,
Emilio
next prev parent reply other threads:[~2018-06-13 3:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 12:56 [Qemu-devel] [PATCH 0/2] cputlb: document iotlb.addr, fix txfail physaddr Peter Maydell
2018-06-11 12:56 ` [Qemu-devel] [PATCH 1/2] cpu-defs.h: Document CPUIOTLBEntry 'addr' field Peter Maydell
2018-06-12 22:09 ` Richard Henderson
2018-06-13 3:33 ` Emilio G. Cota [this message]
2018-06-11 12:56 ` [Qemu-devel] [PATCH 2/2] cputlb: Pass cpu_transaction_failed() the correct physaddr Peter Maydell
2018-06-12 22:11 ` Richard Henderson
2018-06-11 14:01 ` [Qemu-devel] [PATCH 0/2] cputlb: document iotlb.addr, fix txfail physaddr Paolo Bonzini
2018-06-15 10:13 ` Peter Maydell
2018-06-15 15:58 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180613033353.GA25430@flamenco \
--to=cota@braap.org \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).