From: David Gibson <david@gibson.dropbear.id.au>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: groug@kaod.org, qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/7] spapr: Clean up cpu realize/unrealize paths
Date: Wed, 13 Jun 2018 18:52:46 +1000 [thread overview]
Message-ID: <20180613085246.GZ30690@umbus.fritz.box> (raw)
In-Reply-To: <6a1cc08b-5509-f03d-7da7-97429d7003c5@kaod.org>
[-- Attachment #1: Type: text/plain, Size: 951 bytes --]
On Wed, Jun 13, 2018 at 10:11:45AM +0200, Cédric Le Goater wrote:
> On 06/13/2018 08:57 AM, David Gibson wrote:
> > spapr_cpu_init() and spapr_cpu_destroy() are only called from the spapr
> > cpu core realize/unrealize paths, and really can only be called from there.
> >
> > Those are all short functions, so fold the pairs together for simplicity.
> > While we're there rename some functions and change some parameter types
> > for brevity and clarity.
> >
> > Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
>
> Reviewed-by: Cédric Le Goater <clg@kaod.org>
>
> Still a call to spapr_cpu_reset(cpu). We should try to get rid of it
> one day.
Yeah, I know. I'm wrestling with that along with some of the pagesize
stuff.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-06-13 9:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 6:57 [Qemu-devel] [PATCH 0/7] Better handling of machine specific per-cpu information David Gibson
2018-06-13 6:57 ` [Qemu-devel] [PATCH 1/7] spapr: Clean up cpu realize/unrealize paths David Gibson
2018-06-13 8:11 ` Cédric Le Goater
2018-06-13 8:51 ` Greg Kurz
2018-06-13 8:52 ` David Gibson [this message]
2018-06-13 8:34 ` Greg Kurz
2018-06-13 6:57 ` [Qemu-devel] [PATCH 2/7] pnv: Add missing error check during cpu realize() David Gibson
2018-06-13 8:15 ` Cédric Le Goater
2018-06-13 9:12 ` David Gibson
2018-06-13 9:09 ` Greg Kurz
2018-06-13 9:14 ` Cédric Le Goater
2018-06-13 9:42 ` Greg Kurz
2018-06-13 9:53 ` David Gibson
2018-06-14 1:01 ` David Gibson
2018-06-13 9:42 ` David Gibson
2018-06-13 6:57 ` [Qemu-devel] [PATCH 3/7] pnv_core: Allocate cpu thread objects individually David Gibson
2018-06-13 8:17 ` Cédric Le Goater
2018-06-13 9:13 ` Greg Kurz
2018-06-13 6:57 ` [Qemu-devel] [PATCH 4/7] pnv: Clean up cpu realize path David Gibson
2018-06-13 8:20 ` Cédric Le Goater
2018-06-13 9:14 ` David Gibson
2018-06-13 9:15 ` Greg Kurz
2018-06-13 6:57 ` [Qemu-devel] [PATCH 5/7] pnv: Add cpu unrealize path David Gibson
2018-06-13 8:23 ` Cédric Le Goater
2018-06-13 9:16 ` Greg Kurz
2018-06-13 6:57 ` [Qemu-devel] [PATCH 6/7] target/ppc: Replace intc pointer with a general machine_data pointer David Gibson
2018-06-13 8:46 ` Cédric Le Goater
2018-06-13 9:45 ` David Gibson
2018-06-13 10:11 ` Greg Kurz
2018-06-13 10:15 ` David Gibson
2018-06-13 6:57 ` [Qemu-devel] [PATCH 7/7] target/ppc, spapr: Move VPA information to machine_data David Gibson
2018-06-13 10:16 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180613085246.GZ30690@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=clg@kaod.org \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).