From: Stefan Hajnoczi <stefanha@redhat.com>
To: Julia Suvorova <jusual@mail.ru>
Cc: qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Joel Stanley" <joel@jms.id.au>,
"Jim Mussared" <jim@groklearning.com>,
"Steffen Görtz" <mail@steffen-goertz.de>
Subject: Re: [Qemu-devel] [PATCH] target/arm: Allow ARMv6-M Thumb2 instructions
Date: Wed, 13 Jun 2018 15:05:05 +0100 [thread overview]
Message-ID: <20180613140505.GS24528@stefanha-x1.localdomain> (raw)
In-Reply-To: <20180612204632.28780-1-jusual@mail.ru>
[-- Attachment #1: Type: text/plain, Size: 698 bytes --]
On Tue, Jun 12, 2018 at 11:46:32PM +0300, Julia Suvorova wrote:
> ARMv6-M supports 6 Thumb2 instructions. This patch checks for these
> instructions and allows their execution.
> Like Thumb2 cores, ARMv6-M always interprets BL instruction as 32-bit.
>
> This patch is required for future Cortex-M0 support.
>
> Signed-off-by: Julia Suvorova <jusual@mail.ru>
> ---
> target/arm/translate.c | 35 ++++++++++++++++++++++++++++++-----
> 1 file changed, 30 insertions(+), 5 deletions(-)
Does make the undefined instruction test case that I recently posted
pass (including all commented out instructions that weren't working
yet)?
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2018-06-13 14:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 20:46 [Qemu-devel] [PATCH] target/arm: Allow ARMv6-M Thumb2 instructions Julia Suvorova
2018-06-13 14:05 ` Stefan Hajnoczi [this message]
2018-06-13 17:10 ` Julia Suvorova
2018-06-14 8:17 ` Stefan Hajnoczi
2018-06-15 10:55 ` Peter Maydell
2018-06-15 11:15 ` Julia Suvorova
2018-06-17 5:36 ` Richard Henderson
2018-06-17 16:33 ` Peter Maydell
2018-06-17 18:48 ` Julia Suvorova
2018-06-18 10:48 ` Peter Maydell
2018-06-15 13:31 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180613140505.GS24528@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=jim@groklearning.com \
--cc=joel@jms.id.au \
--cc=jusual@mail.ru \
--cc=mail@steffen-goertz.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).