From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fT8Kv-0001u9-Qj for qemu-devel@nongnu.org; Wed, 13 Jun 2018 12:09:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fT8Ks-0006tc-7S for qemu-devel@nongnu.org; Wed, 13 Jun 2018 12:09:29 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:53978 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fT8Ks-0006rW-1v for qemu-devel@nongnu.org; Wed, 13 Jun 2018 12:09:26 -0400 Date: Wed, 13 Jun 2018 17:09:21 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20180613160920.GK2676@work-vm> References: <20180604095520.8563-1-xiaoguangrong@tencent.com> <20180604095520.8563-4-xiaoguangrong@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180604095520.8563-4-xiaoguangrong@tencent.com> Subject: Re: [Qemu-devel] [PATCH 03/12] migration: fix counting xbzrle cache_miss_rate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: guangrong.xiao@gmail.com Cc: pbonzini@redhat.com, mst@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, peterx@redhat.com, jiang.biao2@zte.com.cn, wei.w.wang@intel.com, Xiao Guangrong * guangrong.xiao@gmail.com (guangrong.xiao@gmail.com) wrote: > From: Xiao Guangrong > > Sync up xbzrle_cache_miss_prev only after migration iteration goes > forward > > Signed-off-by: Xiao Guangrong Yeh, I think you're right. Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/ram.c b/migration/ram.c > index dbf24d8c87..dd1283dd45 100644 > --- a/migration/ram.c > +++ b/migration/ram.c > @@ -1189,9 +1189,9 @@ static void migration_bitmap_sync(RAMState *rs) > (double)(xbzrle_counters.cache_miss - > rs->xbzrle_cache_miss_prev) / > (rs->iterations - rs->iterations_prev); > + rs->xbzrle_cache_miss_prev = xbzrle_counters.cache_miss; > } > rs->iterations_prev = rs->iterations; > - rs->xbzrle_cache_miss_prev = xbzrle_counters.cache_miss; > } > > /* reset period counters */ > -- > 2.14.4 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK