qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: "Moger, Babu" <Babu.Moger@amd.com>
Cc: "mst@redhat.com" <mst@redhat.com>,
	"marcel.apfelbaum@gmail.com" <marcel.apfelbaum@gmail.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"rth@twiddle.net" <rth@twiddle.net>,
	"mtosatti@redhat.com" <mtosatti@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"kash@tripleback.net" <kash@tripleback.net>,
	"geoff@hostfission.com" <geoff@hostfission.com>,
	Jiri Denemark <jdenemar@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v13 3/5] i386: Enable TOPOEXT feature on AMD EPYC CPU
Date: Wed, 13 Jun 2018 14:18:20 -0300	[thread overview]
Message-ID: <20180613171820.GC7451@localhost.localdomain> (raw)
In-Reply-To: <DM5PR12MB2471C966B5B16FFCACDF33F3957E0@DM5PR12MB2471.namprd12.prod.outlook.com>

On Wed, Jun 13, 2018 at 04:52:18PM +0000, Moger, Babu wrote:
[...]
> > What do you think our options are here?
> 
> Should we drop automatic topoext completely and move forward?
> What are your thoughts?

Let's drop automatic topoext by now, and see if we find solutions
later.  I don't want to hold the rest of the patches because of
this.

I'm thinking we could simply make kvm_arch_get_supported_cpuid()
always return TOPOEXT on AMD CPUs, because the feature flag don't
really depend on any KVM code to work (is that correct?).

-- 
Eduardo

  reply	other threads:[~2018-06-13 17:18 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-08 22:56 [Qemu-devel] [PATCH v13 0/5] i386: Enable TOPOEXT to support hyperthreading on AMD CPU Babu Moger
2018-06-08 22:56 ` [Qemu-devel] [PATCH v13 1/5] i386: Add support for CPUID_8000_001E for AMD Babu Moger
2018-06-11 20:54   ` Eduardo Habkost
2018-06-11 21:02     ` Moger, Babu
2020-06-02 17:52   ` Eduardo Habkost
2020-06-03 23:57     ` Babu Moger
2020-06-04 14:06     ` Babu Moger
2020-06-04 20:54       ` Eduardo Habkost
2020-06-05 16:21         ` Babu Moger
2018-06-08 22:56 ` [Qemu-devel] [PATCH v13 2/5] i386: Introduce auto_topoext bit to manage topoext Babu Moger
2018-06-11 20:25   ` Moger, Babu
2018-06-11 20:46     ` Eduardo Habkost
2018-06-11 20:59       ` Moger, Babu
2018-06-11 21:05       ` Eduardo Habkost
2018-06-11 21:20         ` Moger, Babu
2018-06-08 22:56 ` [Qemu-devel] [PATCH v13 3/5] i386: Enable TOPOEXT feature on AMD EPYC CPU Babu Moger
2018-06-11 20:50   ` Eduardo Habkost
2018-06-11 21:01     ` Moger, Babu
2018-06-11 21:10     ` Eduardo Habkost
2018-06-12 16:29       ` Moger, Babu
2018-06-12 17:40         ` Eduardo Habkost
2018-06-12 18:38           ` Moger, Babu
2018-06-12 19:05             ` Eduardo Habkost
2018-06-12 19:46               ` Babu Moger
2018-06-13 16:52                 ` Moger, Babu
2018-06-13 17:18                   ` Eduardo Habkost [this message]
2018-06-13 18:10                     ` Moger, Babu
2018-06-13 18:12                       ` Moger, Babu
2018-06-13 18:17                       ` Eduardo Habkost
2018-06-13 18:21                         ` Moger, Babu
2018-06-13 18:49                           ` Eduardo Habkost
2018-06-14  0:58                             ` Moger, Babu
2018-06-08 22:56 ` [Qemu-devel] [PATCH v13 4/5] i386: Verify and enable topoext feature if supported Babu Moger
2018-06-11 20:51   ` Eduardo Habkost
2018-06-11 21:01     ` Moger, Babu
2018-06-08 22:56 ` [Qemu-devel] [PATCH v13 5/5] i386: Remove generic SMT thread check Babu Moger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180613171820.GC7451@localhost.localdomain \
    --to=ehabkost@redhat.com \
    --cc=Babu.Moger@amd.com \
    --cc=geoff@hostfission.com \
    --cc=jdenemar@redhat.com \
    --cc=kash@tripleback.net \
    --cc=kvm@vger.kernel.org \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).