From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fT9Ph-0006u1-0J for qemu-devel@nongnu.org; Wed, 13 Jun 2018 13:18:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fT9Pd-00068q-PE for qemu-devel@nongnu.org; Wed, 13 Jun 2018 13:18:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42198) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fT9Pd-000669-Hu for qemu-devel@nongnu.org; Wed, 13 Jun 2018 13:18:25 -0400 Date: Wed, 13 Jun 2018 14:18:20 -0300 From: Eduardo Habkost Message-ID: <20180613171820.GC7451@localhost.localdomain> References: <1528498581-131037-1-git-send-email-babu.moger@amd.com> <1528498581-131037-4-git-send-email-babu.moger@amd.com> <20180611205030.GW7451@localhost.localdomain> <20180611211026.GA7451@localhost.localdomain> <20180612174021.GL7451@localhost.localdomain> <20180612190554.GO7451@localhost.localdomain> <39f328af-a9c1-15bb-653e-9456b045768d@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v13 3/5] i386: Enable TOPOEXT feature on AMD EPYC CPU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Moger, Babu" Cc: "mst@redhat.com" , "marcel.apfelbaum@gmail.com" , "pbonzini@redhat.com" , "rth@twiddle.net" , "mtosatti@redhat.com" , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , "kash@tripleback.net" , "geoff@hostfission.com" , Jiri Denemark On Wed, Jun 13, 2018 at 04:52:18PM +0000, Moger, Babu wrote: [...] > > What do you think our options are here? > > Should we drop automatic topoext completely and move forward? > What are your thoughts? Let's drop automatic topoext by now, and see if we find solutions later. I don't want to hold the rest of the patches because of this. I'm thinking we could simply make kvm_arch_get_supported_cpuid() always return TOPOEXT on AMD CPUs, because the feature flag don't really depend on any KVM code to work (is that correct?). -- Eduardo