From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fT6jK-0006t5-PU for qemu-devel@nongnu.org; Wed, 13 Jun 2018 10:26:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fT6jG-0003io-TX for qemu-devel@nongnu.org; Wed, 13 Jun 2018 10:26:34 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:48962 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fT6jG-0003fr-O5 for qemu-devel@nongnu.org; Wed, 13 Jun 2018 10:26:30 -0400 Date: Wed, 13 Jun 2018 17:26:28 +0300 From: "Michael S. Tsirkin" Message-ID: <20180613172438-mutt-send-email-mst@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] hw/i386: Fix IVHD entry length for AMD IOMMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel On Tue, May 22, 2018 at 09:06:56AM +0200, Jan Kiszka wrote: > On 2018-03-29 14:51, Jan Kiszka wrote: > > From: Jan Kiszka > > > > Counting from the IVHD ID field to the all-devices entry, we have 28 > > bytes, not 36. > > > > Signed-off-by: Jan Kiszka > > --- > > hw/i386/acpi-build.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > > index deb440f286..a0cda71411 100644 > > --- a/hw/i386/acpi-build.c > > +++ b/hw/i386/acpi-build.c > > @@ -2561,7 +2561,7 @@ build_amd_iommu(GArray *table_data, BIOSLinker *linker) > > (1UL << 7), /* PPRSup */ > > 1); > > /* IVHD length */ > > - build_append_int_noprefix(table_data, 0x24, 2); > > + build_append_int_noprefix(table_data, 28, 2); > > /* DeviceID */ > > build_append_int_noprefix(table_data, s->devid, 2); > > /* Capability offset */ > > > > Waiting to be merged. > > Jan I'll queue this but you really should Cc maintainers :) -- MST