From: Eduardo Habkost <ehabkost@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Cleber Rosa <crosa@redhat.com>,
qemu-devel@nongnu.org, Fam Zheng <famz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Amador Pahim <amador@pahim.org>
Subject: Re: [Qemu-devel] [PATCH v4 5/5] Acceptance tests: add Linux kernel boot and console checking test
Date: Wed, 13 Jun 2018 15:30:41 -0300 [thread overview]
Message-ID: <20180613183041.GF24764@localhost.localdomain> (raw)
In-Reply-To: <a8ec6474-707b-8272-7a79-a842f11d2f7f@amsat.org>
On Wed, May 30, 2018 at 05:57:52PM -0300, Philippe Mathieu-Daudé wrote:
[...]
> > +class BootLinuxConsole(Test):
> > + """
> > + Boots a x86_64 Linux kernel and checks that the console is operational
> > + and the kernel command line is properly passed from QEMU to the kernel
> > +
> > + :avocado: enable
> > + :avocado: tags=x86_64
>
> Can you move tags=x86_64 to the test() method?
I'm queueing this patch as is, as the tag here seems harmless. A
follow-up patch will be required if you want to move the tag.
--
Eduardo
next prev parent reply other threads:[~2018-06-13 18:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 18:41 [Qemu-devel] [PATCH v4 0/5] Acceptance/functional tests Cleber Rosa
2018-05-30 18:41 ` [Qemu-devel] [PATCH v4 1/5] Add functional/acceptance tests infrastructure Cleber Rosa
2018-05-30 21:19 ` Philippe Mathieu-Daudé
2018-05-31 10:55 ` Stefan Hajnoczi
2018-05-30 18:41 ` [Qemu-devel] [PATCH v4 2/5] scripts/qemu.py: allow adding to the list of extra arguments Cleber Rosa
2018-05-30 21:20 ` Philippe Mathieu-Daudé
2018-05-30 18:41 ` [Qemu-devel] [PATCH v4 3/5] Acceptance tests: add quick VNC tests Cleber Rosa
2018-05-30 21:21 ` Philippe Mathieu-Daudé
2018-05-30 18:41 ` [Qemu-devel] [PATCH v4 4/5] scripts/qemu.py: introduce set_console() method Cleber Rosa
2018-05-30 21:22 ` Philippe Mathieu-Daudé
2018-05-31 10:55 ` Stefan Hajnoczi
2018-05-30 18:41 ` [Qemu-devel] [PATCH v4 5/5] Acceptance tests: add Linux kernel boot and console checking test Cleber Rosa
2018-05-30 20:57 ` Philippe Mathieu-Daudé
2018-06-13 18:30 ` Eduardo Habkost [this message]
2018-06-13 18:41 ` Philippe Mathieu-Daudé
2018-05-31 10:56 ` Stefan Hajnoczi
2018-06-05 14:49 ` [Qemu-devel] [PATCH v4 0/5] Acceptance/functional tests Philippe Mathieu-Daudé
2018-06-06 19:26 ` Eduardo Habkost
2018-06-13 18:29 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180613183041.GF24764@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=amador@pahim.org \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).