From: Eduardo Habkost <ehabkost@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
qemu-devel@nongnu.org, "Michael S . Tsirkin" <mst@redhat.com>,
Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
Alexander Graf <agraf@suse.de>,
qemu-ppc@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v1 06/11] pc-dimm: don't allow to access "size" before the device was realized
Date: Wed, 13 Jun 2018 18:33:37 -0300 [thread overview]
Message-ID: <20180613213337.GP7451@localhost.localdomain> (raw)
In-Reply-To: <bb0b033f-d048-06db-96d1-89085000d792@redhat.com>
On Wed, Jun 13, 2018 at 04:03:35PM +0200, David Hildenbrand wrote:
> On 13.06.2018 14:56, Igor Mammedov wrote:
> > On Mon, 11 Jun 2018 14:16:50 +0200
> > David Hildenbrand <david@redhat.com> wrote:
> >
> >> "size" should not be queried before the device was realized. Let' make
> >> that explicit.
> >>
> >> Signed-off-by: David Hildenbrand <david@redhat.com>
> > It's generic property getter, it should work even before realize is called.
>
> That's the point, as we can see in NVDIMM code , it is *not* a generic
> property getter.
If it were a writeable property, I would agree with Igor because
it would make it impossible to find out what's the default value
for the property.
As it's a read-only property, returning an error seems harmless.
Igor, why exactly do you think it's a problem?
--
Eduardo
next prev parent reply other threads:[~2018-06-13 21:33 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 12:16 [Qemu-devel] [PATCH v1 00/11] pc-dimm: next bunch of cleanups David Hildenbrand
2018-06-11 12:16 ` [Qemu-devel] [PATCH v1 01/11] pc-dimm: remove leftover "struct pc_dimms_capacity" David Hildenbrand
2018-06-12 0:21 ` David Gibson
2018-06-13 9:23 ` Igor Mammedov
2018-06-11 12:16 ` [Qemu-devel] [PATCH v1 02/11] nvdimm: no need to overwrite get_vmstate_memory_region() David Hildenbrand
2018-06-12 0:22 ` David Gibson
2018-06-13 9:39 ` Igor Mammedov
2018-06-11 12:16 ` [Qemu-devel] [PATCH v1 03/11] pc: factor out pc-dimm checks into pc_dimm_pre_plug() David Hildenbrand
2018-06-12 0:28 ` David Gibson
2018-06-13 10:07 ` Igor Mammedov
2018-06-11 12:16 ` [Qemu-devel] [PATCH v1 04/11] hostmem: drop error variable from host_memory_backend_get_memory() David Hildenbrand
2018-06-12 0:49 ` David Gibson
2018-06-13 10:13 ` Igor Mammedov
2018-06-11 12:16 ` [Qemu-devel] [PATCH v1 05/11] spapr: move memory hotplug size check into plug code David Hildenbrand
2018-06-12 1:02 ` David Gibson
2018-06-13 11:01 ` Igor Mammedov
2018-06-13 11:05 ` David Hildenbrand
2018-06-13 13:57 ` Igor Mammedov
2018-06-14 7:10 ` David Hildenbrand
2018-06-11 12:16 ` [Qemu-devel] [PATCH v1 06/11] pc-dimm: don't allow to access "size" before the device was realized David Hildenbrand
2018-06-12 1:08 ` David Gibson
2018-06-13 12:56 ` Igor Mammedov
2018-06-13 14:03 ` David Hildenbrand
2018-06-13 21:33 ` Eduardo Habkost [this message]
2018-06-14 13:02 ` Igor Mammedov
2018-06-14 13:24 ` Igor Mammedov
2018-06-14 14:10 ` David Hildenbrand
2018-06-15 9:16 ` Igor Mammedov
2018-06-15 9:25 ` David Hildenbrand
2018-06-15 10:06 ` Igor Mammedov
2018-06-11 12:16 ` [Qemu-devel] [PATCH v1 07/11] pc-dimm: get_memory_region() can never fail David Hildenbrand
2018-06-12 1:10 ` David Gibson
2018-06-13 13:03 ` Igor Mammedov
2018-06-13 14:07 ` David Hildenbrand
2018-06-13 14:50 ` David Hildenbrand
2018-06-14 15:00 ` Igor Mammedov
2018-06-14 15:11 ` David Hildenbrand
2018-06-15 9:59 ` Igor Mammedov
2018-06-15 10:29 ` David Hildenbrand
2018-06-11 12:16 ` [Qemu-devel] [PATCH v1 08/11] pc-dimm: get_memory_region() will never return a NULL pointer David Hildenbrand
2018-06-12 1:12 ` David Gibson
2018-06-11 12:16 ` [Qemu-devel] [PATCH v1 09/11] pc-dimm: remove pc_dimm_get_vmstate_memory_region() David Hildenbrand
2018-06-12 1:29 ` David Gibson
2018-06-11 12:16 ` [Qemu-devel] [PATCH v1 10/11] pc-dimm: introduce and use pc_dimm_memory_pre_plug() David Hildenbrand
2018-06-12 1:48 ` David Gibson
2018-06-13 13:10 ` Igor Mammedov
2018-06-13 14:15 ` David Hildenbrand
2018-06-15 9:34 ` Igor Mammedov
2018-06-15 9:48 ` David Hildenbrand
2018-06-15 10:01 ` Igor Mammedov
2018-06-11 12:16 ` [Qemu-devel] [PATCH v1 11/11] pc-dimm: assign and verify the "slot" property during pre_plug David Hildenbrand
2018-06-12 2:02 ` David Gibson
2018-06-13 13:34 ` [Qemu-devel] [PATCH v1 00/11] pc-dimm: next bunch of cleanups Igor Mammedov
2018-06-13 14:11 ` David Hildenbrand
2018-06-15 10:59 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180613213337.GP7451@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).