Re: [Qemu-devel] [PATCH] target/arm: Allow ARMv6-M Thumb2 instructions

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

On Wed, Jun 13, 2018 at 08:10:23PM +0300, Julia Suvorova via Qemu-devel wrote:
> On 13.06.2018 17:05, Stefan Hajnoczi wrote:
> > On Tue, Jun 12, 2018 at 11:46:32PM +0300, Julia Suvorova wrote:
> > > ARMv6-M supports 6 Thumb2 instructions. This patch checks for these
> > > instructions and allows their execution.
> > > Like Thumb2 cores, ARMv6-M always interprets BL instruction as 32-bit.
> > > 
> > > This patch is required for future Cortex-M0 support.
> > > 
> > > Signed-off-by: Julia Suvorova <jusual@mail.ru>
> > > ---
> > >   target/arm/translate.c | 35 ++++++++++++++++++++++++++++++-----
> > >   1 file changed, 30 insertions(+), 5 deletions(-)
> > 
> > Does make the undefined instruction test case that I recently posted
> > pass (including all commented out instructions that weren't working
> > yet)?
> > 
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> > 
> 
> Yes, test with all instructions is passed.

Great, I have sent a v2 of that patch.  It now also includes the 6 valid
32-bit instructions to prove that your patch has enabled them.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]