From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTNZH-0005Wk-FD for qemu-devel@nongnu.org; Thu, 14 Jun 2018 04:25:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTNZD-0006rz-Bc for qemu-devel@nongnu.org; Thu, 14 Jun 2018 04:25:19 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:58794 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fTNZD-0006rk-0C for qemu-devel@nongnu.org; Thu, 14 Jun 2018 04:25:15 -0400 Date: Thu, 14 Jun 2018 09:25:09 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180614082509.GK6355@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <1528933916-40670-1-git-send-email-keno@juliacomputing.com> <20180614082355.GJ6355@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180614082355.GJ6355@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] ui: darwin: gtk: Add missing input keymap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Keno Fischer , Gerd Hoffmann Cc: qemu-devel@nongnu.org CC'ing Gerd as ui/ tree maintainer. On Thu, Jun 14, 2018 at 09:23:55AM +0100, Daniel P. Berrang=C3=A9 wrote: > On Wed, Jun 13, 2018 at 07:51:56PM -0400, Keno Fischer wrote: > > In appears the input keymap for osx was forgotten in the commit that > > converted the gtk frontend to keycodemapdb. Add it. > >=20 > > Fixes: 2ec78706 ("ui: convert GTK and SDL1 frontends to keycodemapdb"= ) > > CC: Daniel P. Berrange > > Signed-off-by: Keno Fischer > > --- > > Makefile | 1 + > > include/ui/input.h | 3 +++ > > ui/input-keymap.c | 1 + > > 3 files changed, 5 insertions(+) >=20 > Reviewed-by: Daniel P. Berrang=C3=A9 >=20 > I guess this shows just how (in-)frequently people try to compile the G= TK > frontend on OS-X :-( >=20 > >=20 > > diff --git a/Makefile b/Makefile > > index 6a5fff0..1e79914 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -322,6 +322,7 @@ KEYCODEMAP_FILES =3D \ > > ui/input-keymap-xorgkbd-to-qcode.c \ > > ui/input-keymap-xorgxquartz-to-qcode.c \ > > ui/input-keymap-xorgxwin-to-qcode.c \ > > + ui/input-keymap-osx-to-qcode.c \ > > $(NULL) > > =20 > > GENERATED_FILES +=3D $(KEYCODEMAP_FILES) > > diff --git a/include/ui/input.h b/include/ui/input.h > > index 16395ab..34ebc67 100644 > > --- a/include/ui/input.h > > +++ b/include/ui/input.h > > @@ -116,4 +116,7 @@ extern const guint16 qemu_input_map_xorgxquartz_t= o_qcode[]; > > extern const guint qemu_input_map_xorgxwin_to_qcode_len; > > extern const guint16 qemu_input_map_xorgxwin_to_qcode[]; > > =20 > > +extern const guint qemu_input_map_osx_to_qcode_len; > > +extern const guint16 qemu_input_map_osx_to_qcode[]; > > + > > #endif /* INPUT_H */ > > diff --git a/ui/input-keymap.c b/ui/input-keymap.c > > index 87cc301..db5ccff 100644 > > --- a/ui/input-keymap.c > > +++ b/ui/input-keymap.c > > @@ -21,6 +21,7 @@ > > #include "ui/input-keymap-xorgkbd-to-qcode.c" > > #include "ui/input-keymap-xorgxquartz-to-qcode.c" > > #include "ui/input-keymap-xorgxwin-to-qcode.c" > > +#include "ui/input-keymap-osx-to-qcode.c" > > =20 > > int qemu_input_linux_to_qcode(unsigned int lnx) > > { > > --=20 > > 2.8.1 > >=20 >=20 > Regards, > Daniel > --=20 > |: https://berrange.com -o- https://www.flickr.com/photos/dberr= ange :| > |: https://libvirt.org -o- https://fstop138.berrange= .com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberr= ange :| >=20 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|