qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, mreitz@redhat.com, armbru@redhat.com,
	jcody@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 4/4] block: Remove dead deprecation warning code
Date: Thu, 14 Jun 2018 11:55:44 +0200	[thread overview]
Message-ID: <20180614095544.31549-5-kwolf@redhat.com> (raw)
In-Reply-To: <20180614095544.31549-1-kwolf@redhat.com>

We removed all options from the 'deprecated' array, so the code is dead
and can be removed as well.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 blockdev.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/blockdev.c b/blockdev.c
index 695e10d398..4ab3d6ec0b 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -774,8 +774,6 @@ DriveInfo *drive_new(QemuOpts *all_opts, BlockInterfaceType block_default_type)
     const char *filename;
     Error *local_err = NULL;
     int i;
-    const char *deprecated[] = {
-    };
 
     /* Change legacy command line options into QMP ones */
     static const struct {
@@ -852,16 +850,6 @@ DriveInfo *drive_new(QemuOpts *all_opts, BlockInterfaceType block_default_type)
         goto fail;
     }
 
-    /* Other deprecated options */
-    if (!qtest_enabled()) {
-        for (i = 0; i < ARRAY_SIZE(deprecated); i++) {
-            if (qemu_opt_get(legacy_opts, deprecated[i]) != NULL) {
-                error_report("'%s' is deprecated, please use the corresponding "
-                             "option of '-device' instead", deprecated[i]);
-            }
-        }
-    }
-
     /* Media type */
     value = qemu_opt_get(legacy_opts, "media");
     if (value) {
-- 
2.13.6

  parent reply	other threads:[~2018-06-14  9:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-14  9:55 [Qemu-devel] [PATCH v2 0/4] block: Remove deprecated -drive options Kevin Wolf
2018-06-14  9:55 ` [Qemu-devel] [PATCH v2 1/4] block: Remove deprecated -drive geometry options Kevin Wolf
2018-06-14 13:17   ` Markus Armbruster
2018-06-14  9:55 ` [Qemu-devel] [PATCH v2 2/4] block: Remove deprecated -drive option addr Kevin Wolf
2018-06-14  9:55 ` [Qemu-devel] [PATCH v2 3/4] block: Remove deprecated -drive option serial Kevin Wolf
2018-06-14 13:09   ` Richard W.M. Jones
2018-06-14 13:41     ` Kevin Wolf
2018-06-14  9:55 ` Kevin Wolf [this message]
2018-06-14 13:17   ` [Qemu-devel] [PATCH v2 4/4] block: Remove dead deprecation warning code Markus Armbruster
2018-06-15 12:49 ` [Qemu-devel] [PATCH v2 0/4] block: Remove deprecated -drive options Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180614095544.31549-5-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=armbru@redhat.com \
    --cc=jcody@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).