From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PULL v2 2/3] coverity-model: replay data is considered trusted
Date: Thu, 14 Jun 2018 14:43:29 +0200 [thread overview]
Message-ID: <20180614124330.12224-3-armbru@redhat.com> (raw)
In-Reply-To: <20180614124330.12224-1-armbru@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Replay data is not considered a possible attack vector; add a model that
does not use getc so that "tainted data" warnings are suppressed.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20180514141218.28438-1-pbonzini@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Whitespace tweaked]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
scripts/coverity-model.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/scripts/coverity-model.c b/scripts/coverity-model.c
index c702804f41..2ec753db05 100644
--- a/scripts/coverity-model.c
+++ b/scripts/coverity-model.c
@@ -103,6 +103,18 @@ static int get_keysym(const name2keysym_t *table,
}
}
+/* Replay data is considered trusted. */
+uint8_t replay_get_byte(void)
+{
+ uint8_t byte = 0;
+ if (replay_file) {
+ uint8_t c;
+ byte = c;
+ }
+ return byte;
+}
+
+
/*
* GLib memory allocation functions.
*
--
2.17.1
next prev parent reply other threads:[~2018-06-14 12:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 12:43 [Qemu-devel] [PULL v2 0/3] Miscellaneous patches for 2018-06-13 Markus Armbruster
2018-06-14 12:43 ` [Qemu-devel] [PULL v2 1/3] Revert "Makefile: add target to print generated files" Markus Armbruster
2018-06-14 12:43 ` Markus Armbruster [this message]
2018-06-14 12:43 ` [Qemu-devel] [PULL v2 3/3] Purge uses of banned g_assert_FOO() Markus Armbruster
2018-06-14 12:49 ` [Qemu-devel] [PULL v2 0/3] Miscellaneous patches for 2018-06-13 Peter Maydell
2018-06-14 13:12 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614124330.12224-3-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).