* [Qemu-devel] [PATCH v1 0/3] Current Travis Patches
@ 2018-06-14 12:53 Alex Bennée
2018-06-14 12:53 ` [Qemu-devel] [PATCH v1 1/3] travis: display config.log when configure fails Alex Bennée
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Alex Bennée @ 2018-06-14 12:53 UTC (permalink / raw)
To: famz, pbonzini, stefanha, stefanb, marcandre.lureau
Cc: qemu-devel, Alex Bennée
Hi,
Mine are mostly aimed at reducing the build time of a number of bits
of the matrix which keep tripping up on the time limit. I'll put the
pull-req in tomorrow if there are no major complaints.
Alex Bennée (2):
travis: reduce coverage of gprof build
travis: reduce time taken for trace-backend testing
Daniel P. Berrangé (1):
travis: display config.log when configure fails
.travis.yml | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH v1 1/3] travis: display config.log when configure fails
2018-06-14 12:53 [Qemu-devel] [PATCH v1 0/3] Current Travis Patches Alex Bennée
@ 2018-06-14 12:53 ` Alex Bennée
2018-06-14 12:53 ` [Qemu-devel] [PATCH v1 2/3] travis: reduce coverage of gprof build Alex Bennée
2018-06-14 12:53 ` [Qemu-devel] [PATCH v1 3/3] travis: reduce time taken for trace-backend testing Alex Bennée
2 siblings, 0 replies; 6+ messages in thread
From: Alex Bennée @ 2018-06-14 12:53 UTC (permalink / raw)
To: famz, pbonzini, stefanha, stefanb, marcandre.lureau
Cc: qemu-devel, Daniel P. Berrangé, Alex Bennée,
Philippe Mathieu-Daudé
From: Daniel P. Berrangé <berrange@redhat.com>
When configure fails in CI systems we must be able to see the contents
of the config.log file to diagnose the root cause.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Fam Zheng <famz@redhat.com>
[AJB: used Eric's suggested {} form]
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
.travis.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 814be151f4..d5e6d50e6d 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -69,7 +69,7 @@ before_install:
- wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
- git submodule update --init --recursive
before_script:
- - ./configure ${CONFIG}
+ - ./configure ${CONFIG} || { cat config.log && exit 1; }
script:
- make ${MAKEFLAGS} && ${TEST_CMD}
matrix:
@@ -151,4 +151,4 @@ matrix:
- CONFIG="--cc=gcc-7 --cxx=g++-7 --disable-pie --disable-linux-user"
- TEST_CMD=""
before_script:
- - ./configure ${CONFIG} --extra-cflags="-g3 -O0 -fsanitize=thread -fuse-ld=gold" || cat config.log
+ - ./configure ${CONFIG} --extra-cflags="-g3 -O0 -fsanitize=thread -fuse-ld=gold" || { cat config.log && exit 1; }
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH v1 2/3] travis: reduce coverage of gprof build
2018-06-14 12:53 [Qemu-devel] [PATCH v1 0/3] Current Travis Patches Alex Bennée
2018-06-14 12:53 ` [Qemu-devel] [PATCH v1 1/3] travis: display config.log when configure fails Alex Bennée
@ 2018-06-14 12:53 ` Alex Bennée
2018-06-14 13:05 ` Philippe Mathieu-Daudé
2018-06-14 12:53 ` [Qemu-devel] [PATCH v1 3/3] travis: reduce time taken for trace-backend testing Alex Bennée
2 siblings, 1 reply; 6+ messages in thread
From: Alex Bennée @ 2018-06-14 12:53 UTC (permalink / raw)
To: famz, pbonzini, stefanha, stefanb, marcandre.lureau
Cc: qemu-devel, Alex Bennée, Philippe Mathieu-Daudé
This build is regularly timing out and even switching off linux-user
wasn't enough. Instead explicitly choose a target list of broadly the
"major" architectures. This is enough to check the gprof build
machinery works without worrying about the actual coverage results.
I did try various YAML constructs for specifying CONFIG with
continuation but couldn't get any of them to work hence the very long
line.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
.travis.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.travis.yml b/.travis.yml
index d5e6d50e6d..c200dde534 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -80,7 +80,7 @@ matrix:
- env: CONFIG="--disable-user"
compiler: clang
# gprof/gcov are GCC features
- - env: CONFIG="--enable-gprof --enable-gcov --disable-pie --disable-linux-user"
+ - env: CONFIG="--enable-gprof --enable-gcov --disable-pie --target-list=aarch64-softmmu,arm-softmmu,i386-softmmu,mips-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s390x-softmmu,x86_64-softmmu"
compiler: gcc
# We manually include builds which we disable "make check" for
- env: CONFIG="--enable-debug --enable-tcg-interpreter"
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH v1 3/3] travis: reduce time taken for trace-backend testing
2018-06-14 12:53 [Qemu-devel] [PATCH v1 0/3] Current Travis Patches Alex Bennée
2018-06-14 12:53 ` [Qemu-devel] [PATCH v1 1/3] travis: display config.log when configure fails Alex Bennée
2018-06-14 12:53 ` [Qemu-devel] [PATCH v1 2/3] travis: reduce coverage of gprof build Alex Bennée
@ 2018-06-14 12:53 ` Alex Bennée
2018-06-14 13:06 ` Philippe Mathieu-Daudé
2 siblings, 1 reply; 6+ messages in thread
From: Alex Bennée @ 2018-06-14 12:53 UTC (permalink / raw)
To: famz, pbonzini, stefanha, stefanb, marcandre.lureau
Cc: qemu-devel, Alex Bennée, Philippe Mathieu-Daudé
These builds are reaching regular timeouts and probably don't need to
be so widely exercised. ftrace and ust in particular are used in
conjunction with whole system profiling which makes most sense with
KVM setups, hence the native softmmu target.
We also expand simple to cover the multiple log backends while
restricting its scope to user-mode testing only.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
.travis.yml | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index c200dde534..fabfe9ec34 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -86,13 +86,14 @@ matrix:
- env: CONFIG="--enable-debug --enable-tcg-interpreter"
TEST_CMD=""
compiler: gcc
- - env: CONFIG="--enable-trace-backends=simple"
+ # We don't need to exercise every backend with every front-end
+ - env: CONFIG="--enable-trace-backends=log,simple,syslog --disable-system"
TEST_CMD=""
compiler: gcc
- - env: CONFIG="--enable-trace-backends=ftrace"
+ - env: CONFIG="--enable-trace-backends=ftrace --target-list=x86_64-softmmu"
TEST_CMD=""
compiler: gcc
- - env: CONFIG="--enable-trace-backends=ust"
+ - env: CONFIG="--enable-trace-backends=ust --target-list=x86_64-softmmu"
TEST_CMD=""
compiler: gcc
- env: CONFIG="--disable-tcg"
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v1 2/3] travis: reduce coverage of gprof build
2018-06-14 12:53 ` [Qemu-devel] [PATCH v1 2/3] travis: reduce coverage of gprof build Alex Bennée
@ 2018-06-14 13:05 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-06-14 13:05 UTC (permalink / raw)
To: Alex Bennée, famz, pbonzini, stefanha, stefanb,
marcandre.lureau
Cc: qemu-devel
On 06/14/2018 09:53 AM, Alex Bennée wrote:
> This build is regularly timing out and even switching off linux-user
> wasn't enough. Instead explicitly choose a target list of broadly the
> "major" architectures. This is enough to check the gprof build
> machinery works without worrying about the actual coverage results.
>
> I did try various YAML constructs for specifying CONFIG with
> continuation but couldn't get any of them to work hence the very long
> line.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> .travis.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index d5e6d50e6d..c200dde534 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -80,7 +80,7 @@ matrix:
> - env: CONFIG="--disable-user"
> compiler: clang
> # gprof/gcov are GCC features
> - - env: CONFIG="--enable-gprof --enable-gcov --disable-pie --disable-linux-user"
> + - env: CONFIG="--enable-gprof --enable-gcov --disable-pie --target-list=aarch64-softmmu,arm-softmmu,i386-softmmu,mips-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s390x-softmmu,x86_64-softmmu"
> compiler: gcc
> # We manually include builds which we disable "make check" for
> - env: CONFIG="--enable-debug --enable-tcg-interpreter"
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v1 3/3] travis: reduce time taken for trace-backend testing
2018-06-14 12:53 ` [Qemu-devel] [PATCH v1 3/3] travis: reduce time taken for trace-backend testing Alex Bennée
@ 2018-06-14 13:06 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-06-14 13:06 UTC (permalink / raw)
To: Alex Bennée, famz, pbonzini, stefanha, stefanb,
marcandre.lureau
Cc: qemu-devel
On 06/14/2018 09:53 AM, Alex Bennée wrote:
> These builds are reaching regular timeouts and probably don't need to
> be so widely exercised. ftrace and ust in particular are used in
> conjunction with whole system profiling which makes most sense with
> KVM setups, hence the native softmmu target.
>
> We also expand simple to cover the multiple log backends while
> restricting its scope to user-mode testing only.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> .travis.yml | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index c200dde534..fabfe9ec34 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -86,13 +86,14 @@ matrix:
> - env: CONFIG="--enable-debug --enable-tcg-interpreter"
> TEST_CMD=""
> compiler: gcc
> - - env: CONFIG="--enable-trace-backends=simple"
> + # We don't need to exercise every backend with every front-end
> + - env: CONFIG="--enable-trace-backends=log,simple,syslog --disable-system"
> TEST_CMD=""
> compiler: gcc
> - - env: CONFIG="--enable-trace-backends=ftrace"
> + - env: CONFIG="--enable-trace-backends=ftrace --target-list=x86_64-softmmu"
> TEST_CMD=""
> compiler: gcc
> - - env: CONFIG="--enable-trace-backends=ust"
> + - env: CONFIG="--enable-trace-backends=ust --target-list=x86_64-softmmu"
> TEST_CMD=""
> compiler: gcc
> - env: CONFIG="--disable-tcg"
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-06-14 13:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-14 12:53 [Qemu-devel] [PATCH v1 0/3] Current Travis Patches Alex Bennée
2018-06-14 12:53 ` [Qemu-devel] [PATCH v1 1/3] travis: display config.log when configure fails Alex Bennée
2018-06-14 12:53 ` [Qemu-devel] [PATCH v1 2/3] travis: reduce coverage of gprof build Alex Bennée
2018-06-14 13:05 ` Philippe Mathieu-Daudé
2018-06-14 12:53 ` [Qemu-devel] [PATCH v1 3/3] travis: reduce time taken for trace-backend testing Alex Bennée
2018-06-14 13:06 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).