From: Kevin Wolf <kwolf@redhat.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: qemu-block@nongnu.org, jcody@redhat.com, qemu-devel@nongnu.org,
armbru@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 3/4] block: Remove deprecated -drive option serial
Date: Thu, 14 Jun 2018 15:41:13 +0200 [thread overview]
Message-ID: <20180614134113.GI8564@localhost.localdomain> (raw)
In-Reply-To: <20180614130912.GA16293@redhat.com>
Am 14.06.2018 um 15:09 hat Richard W.M. Jones geschrieben:
> On Thu, Jun 14, 2018 at 11:55:43AM +0200, Kevin Wolf wrote:
> > The -drive option serial was deprecated in QEMU 2.10. It's time to
> > remove it.
> >
> > Tests need to be updated to set the serial number with -global instead
> > of using the -drive option.
>
> Libguestfs uses this option to set the disk serial/label. What is
> the alternate syntax?
Just set it in -device (for the disk, e.g. the one for ide-hd) rather
than -drive.
Kevin
next prev parent reply other threads:[~2018-06-14 13:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 9:55 [Qemu-devel] [PATCH v2 0/4] block: Remove deprecated -drive options Kevin Wolf
2018-06-14 9:55 ` [Qemu-devel] [PATCH v2 1/4] block: Remove deprecated -drive geometry options Kevin Wolf
2018-06-14 13:17 ` Markus Armbruster
2018-06-14 9:55 ` [Qemu-devel] [PATCH v2 2/4] block: Remove deprecated -drive option addr Kevin Wolf
2018-06-14 9:55 ` [Qemu-devel] [PATCH v2 3/4] block: Remove deprecated -drive option serial Kevin Wolf
2018-06-14 13:09 ` Richard W.M. Jones
2018-06-14 13:41 ` Kevin Wolf [this message]
2018-06-14 9:55 ` [Qemu-devel] [PATCH v2 4/4] block: Remove dead deprecation warning code Kevin Wolf
2018-06-14 13:17 ` Markus Armbruster
2018-06-15 12:49 ` [Qemu-devel] [PATCH v2 0/4] block: Remove deprecated -drive options Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614134113.GI8564@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=jcody@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).