From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTSV9-0006EB-Md for qemu-devel@nongnu.org; Thu, 14 Jun 2018 09:41:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTSV8-0002Iz-RM for qemu-devel@nongnu.org; Thu, 14 Jun 2018 09:41:23 -0400 Date: Thu, 14 Jun 2018 15:41:13 +0200 From: Kevin Wolf Message-ID: <20180614134113.GI8564@localhost.localdomain> References: <20180614095544.31549-1-kwolf@redhat.com> <20180614095544.31549-4-kwolf@redhat.com> <20180614130912.GA16293@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180614130912.GA16293@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 3/4] block: Remove deprecated -drive option serial List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Richard W.M. Jones" Cc: qemu-block@nongnu.org, jcody@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, mreitz@redhat.com Am 14.06.2018 um 15:09 hat Richard W.M. Jones geschrieben: > On Thu, Jun 14, 2018 at 11:55:43AM +0200, Kevin Wolf wrote: > > The -drive option serial was deprecated in QEMU 2.10. It's time to > > remove it. > > > > Tests need to be updated to set the serial number with -global instead > > of using the -drive option. > > Libguestfs uses this option to set the disk serial/label. What is > the alternate syntax? Just set it in -device (for the disk, e.g. the one for ide-hd) rather than -drive. Kevin