From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Emilio G . Cota" <cota@braap.org>,
"Richard Henderson" <rth@twiddle.net>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Hervé Poussineau" <hpoussin@reactos.org>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [RFC PATCH 0/2] smc37c669: Fix parallel overlapping VGA ioport
Date: Thu, 14 Jun 2018 15:01:17 -0300 [thread overview]
Message-ID: <20180614180119.1704-1-f4bug@amsat.org> (raw)
Hi,
This RFC series attempt to fix a regression introduced in a4cb773928e,
and reported by Emilio:
http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg00317.html
Mark noticed the VGA and parallel I/O were overlapping:
(qemu) info mtree
address-space: memory
0000000000000000-ffffffffffffffff (prio 0, i/o): system
00000801fc000000-00000801fdffffff (prio 0, i/o): pci0-io
...
00000801fc0003b4-00000801fc0003b5 (prio 0, i/o): vga
00000801fc0003ba-00000801fc0003ba (prio 0, i/o): vga
00000801fc0003bc-00000801fc0003c3 (prio 0, i/o): parallel
^^^ ^^^^^^^^
00000801fc0003c0-00000801fc0003cf (prio 0, i/o): vga
^^^
00000801fc0003d4-00000801fc0003d5 (prio 0, i/o): vga
00000801fc0003da-00000801fc0003da (prio 0, i/o): vga
...
In reset the parallel port is enabled. Since the emulated PALcode
directly accesses the VGA port without checking if the SIO parallel
port is enabled, I suppose the real PALcode does this check.
To avoid changing the emulated PALcode, a "parallel" property is used
to reset the SIO with the parallel device disabled.
I tried to implement the quickest simpler fix...
references used:
- http://www.osdever.net/FreeVGA/vga/portidx.htm
- https://retired.beyondlogic.org/spp/parallel.htm
- http://ww1.microchip.com/downloads/en/DeviceDoc/37c669.pdf
- linux/arch/alpha/kernel/smc37c669.c
- https://github.com/rth7680/qemu-palcode/blob/master/init.c#L290
- https://github.com/rth7680/qemu-palcode/blob/master/ioport.h#L48
Regards,
Phil.
Philippe Mathieu-Daudé (2):
hw/isa/smc37c669-superio: Basic 'Config Registers' implementation
hw/alpha/dp264: Disable the Super I/O parallel port
hw/alpha/dp264.c | 6 +++-
hw/isa/smc37c669-superio.c | 73 +++++++++++++++++++++++++++++++++-----
2 files changed, 70 insertions(+), 9 deletions(-)
--
2.17.1
next reply other threads:[~2018-06-14 18:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 18:01 Philippe Mathieu-Daudé [this message]
2018-06-14 18:01 ` [Qemu-devel] [RFC PATCH 1/2] hw/isa/smc37c669-superio: Basic 'Config Registers' implementation Philippe Mathieu-Daudé
2018-06-14 18:19 ` Paolo Bonzini
2018-06-14 21:14 ` Richard Henderson
2018-06-14 21:24 ` Paolo Bonzini
2018-06-14 18:01 ` [Qemu-devel] [RFC PATCH 2/2] hw/alpha/dp264: Disable the Super I/O parallel port Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614180119.1704-1-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=cota@braap.org \
--cc=hpoussin@reactos.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).