From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, "Emilio G. Cota" <cota@braap.org>
Subject: [Qemu-devel] [PULL v2 17/19] translate-all: remove tb_lock mention from cpu_restore_state_from_tb
Date: Fri, 15 Jun 2018 09:43:52 -1000 [thread overview]
Message-ID: <20180615194354.12489-18-richard.henderson@linaro.org> (raw)
In-Reply-To: <20180615194354.12489-1-richard.henderson@linaro.org>
From: "Emilio G. Cota" <cota@braap.org>
tb_lock was needed when the function did retranslation. However,
since fca8a500d519 ("tcg: Save insn data and use it in
cpu_restore_state_from_tb") we don't do retranslation.
Get rid of the comment.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Emilio G. Cota <cota@braap.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
accel/tcg/translate-all.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index 55c9e1b196..b33cd9bc98 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -355,7 +355,6 @@ static int encode_search(TranslationBlock *tb, uint8_t *block)
}
/* The cpu state corresponding to 'searched_pc' is restored.
- * Called with tb_lock held.
* When reset_icount is true, current TB will be interrupted and
* icount should be recalculated.
*/
--
2.17.1
next prev parent reply other threads:[~2018-06-15 19:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 19:43 [Qemu-devel] [PULL v2 00/19] tcg queued patches Richard Henderson
2018-06-15 19:43 ` [Qemu-devel] [PULL v2 01/19] tcg/i386: Use byte form of xgetbv instruction Richard Henderson
2018-06-15 19:43 ` [Qemu-devel] [PULL v2 02/19] qht: require a default comparison function Richard Henderson
2018-06-15 19:43 ` [Qemu-devel] [PULL v2 03/19] qht: return existing entry when qht_insert fails Richard Henderson
2018-06-15 19:43 ` [Qemu-devel] [PULL v2 04/19] tcg: track TBs with per-region BST's Richard Henderson
2018-06-15 19:43 ` [Qemu-devel] [PULL v2 05/19] tcg: move tb_ctx.tb_phys_invalidate_count to tcg_ctx Richard Henderson
2018-06-15 19:43 ` [Qemu-devel] [PULL v2 06/19] translate-all: iterate over TBs in a page with PAGE_FOR_EACH_TB Richard Henderson
2018-06-15 19:43 ` [Qemu-devel] [PULL v2 07/19] translate-all: make l1_map lockless Richard Henderson
2018-06-15 19:43 ` [Qemu-devel] [PULL v2 08/19] translate-all: remove hole in PageDesc Richard Henderson
2018-06-15 19:43 ` [Qemu-devel] [PULL v2 09/19] translate-all: work page-by-page in tb_invalidate_phys_range_1 Richard Henderson
2018-06-15 19:43 ` [Qemu-devel] [PULL v2 10/19] translate-all: move tb_invalidate_phys_page_range up in the file Richard Henderson
2018-06-15 19:43 ` [Qemu-devel] [PULL v2 11/19] translate-all: use per-page locking in !user-mode Richard Henderson
2018-06-15 19:43 ` [Qemu-devel] [PULL v2 12/19] translate-all: add page_locked assertions Richard Henderson
2018-06-15 19:43 ` [Qemu-devel] [PULL v2 13/19] translate-all: introduce assert_no_pages_locked Richard Henderson
2018-06-15 19:43 ` [Qemu-devel] [PULL v2 14/19] translate-all: discard TB when tb_link_page returns an existing matching TB Richard Henderson
2018-06-15 19:43 ` [Qemu-devel] [PULL v2 15/19] translate-all: protect TB jumps with a per-destination-TB lock Richard Henderson
2018-06-15 19:43 ` [Qemu-devel] [PULL v2 16/19] cputlb: remove tb_lock from tlb_flush functions Richard Henderson
2018-06-15 19:43 ` Richard Henderson [this message]
2018-06-15 19:43 ` [Qemu-devel] [PULL v2 18/19] tcg: remove tb_lock Richard Henderson
2018-06-15 19:43 ` [Qemu-devel] [PULL v2 19/19] tcg: Reduce max TB opcode count Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180615194354.12489-18-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=cota@braap.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).