From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Gerd Hoffmann" <kraxel@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PULL 1/3] Revert "usb-ccid: fix bus leak"
Date: Mon, 18 Jun 2018 11:21:30 +0200 [thread overview]
Message-ID: <20180618092132.7253-2-kraxel@redhat.com> (raw)
In-Reply-To: <20180618092132.7253-1-kraxel@redhat.com>
From: Marc-André Lureau <marcandre.lureau@redhat.com>
The bus is not owned by the device.
This reverts commit 410a096adf991ce437d4d7dabc59b6557e6d488d.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 20180613172815.32738-2-marcandre.lureau@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb/dev-smartcard-reader.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c
index fa546fb3ce..13d0befd9c 100644
--- a/hw/usb/dev-smartcard-reader.c
+++ b/hw/usb/dev-smartcard-reader.c
@@ -1147,7 +1147,6 @@ static void ccid_unrealize(USBDevice *dev, Error **errp)
USBCCIDState *s = USB_CCID_DEV(dev);
ccid_bulk_in_clear(s);
- object_unref(OBJECT(&s->bus));
}
static void ccid_flush_pending_answers(USBCCIDState *s)
--
2.9.3
next prev parent reply other threads:[~2018-06-18 9:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 9:21 [Qemu-devel] [PULL 0/3] Usb 20180618 patches Gerd Hoffmann
2018-06-18 9:21 ` Gerd Hoffmann [this message]
2018-06-18 9:21 ` [Qemu-devel] [PULL 2/3] Revert "usb: release the created buses" Gerd Hoffmann
2018-06-18 9:21 ` [Qemu-devel] [PULL 3/3] Revert "bus: do not unref the added child bus on realize" Gerd Hoffmann
2018-06-19 12:43 ` [Qemu-devel] [PULL 0/3] Usb 20180618 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618092132.7253-2-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).