From: "Alex Bennée" <alex.bennee@linaro.org>
To: famz@redhat.com, cota@braap.org, berrange@redhat.com,
f4bug@amsat.org, richard.henderson@linaro.org, balrogg@gmail.com,
aurelien@aurel32.net, agraf@suse.de
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [Qemu-devel] [PATCH v1 6/8] docker: docker.py don't conflate checksums for extra_files
Date: Mon, 18 Jun 2018 14:07:07 +0100 [thread overview]
Message-ID: <20180618130709.19730-7-alex.bennee@linaro.org> (raw)
In-Reply-To: <20180618130709.19730-1-alex.bennee@linaro.org>
This just gets confusing especially as the helper function doesn't
even take into account any extra files (or the executable). Currently
the actual check just ignores them and also passes the result through
_dockerfile_preprocess so we fix that too.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/docker/docker.py | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tests/docker/docker.py b/tests/docker/docker.py
index 3072bf4a31..325915a6f9 100755
--- a/tests/docker/docker.py
+++ b/tests/docker/docker.py
@@ -201,8 +201,10 @@ class Docker(object):
tmp_df.write("\n")
tmp_df.write("LABEL com.qemu.dockerfile-checksum=%s" %
- _text_checksum("\n".join([dockerfile] +
- extra_files_cksum)))
+ _text_checksum(_dockerfile_preprocess(dockerfile)))
+ for f, c in extra_files_cksum:
+ tmp_df.write("LABEL com.qemu.%s-checksum=%s" % (f, c))
+
tmp_df.flush()
self._do_check(["build", "-t", tag, "-f", tmp_df.name] + argv + \
@@ -317,7 +319,7 @@ class BuildCommand(SubCommand):
_copy_binary_with_libs(args.include_executable, docker_dir)
for filename in args.extra_files or []:
_copy_with_mkdir(filename, docker_dir)
- cksum += [_file_checksum(filename)]
+ cksum += [(filename, _file_checksum(filename))]
argv += ["--build-arg=" + k.lower() + "=" + v
for k, v in os.environ.iteritems()
--
2.17.1
next prev parent reply other threads:[~2018-06-18 13:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 13:07 [Qemu-devel] [PATCH v1 0/8] Docker tweaks for TCG testing Alex Bennée
2018-06-18 13:07 ` [Qemu-devel] [PATCH v1 1/8] docker: Add "cc" subcommand Alex Bennée
2018-06-18 13:07 ` [Qemu-devel] [PATCH v1 2/8] docker: extend "cc" command to accept compiler Alex Bennée
2018-06-18 13:07 ` [Qemu-devel] [PATCH v1 3/8] docker: allow "cc" command to run in user context Alex Bennée
2018-06-18 13:07 ` [Qemu-devel] [PATCH v1 4/8] docker: Makefile.include introduce DOCKER_SCRIPT Alex Bennée
2018-06-18 13:07 ` [Qemu-devel] [PATCH v1 5/8] docker: docker.py use "ps" to probe usage Alex Bennée
2018-06-18 15:00 ` Philippe Mathieu-Daudé
2018-06-18 13:07 ` Alex Bennée [this message]
2018-06-18 16:01 ` [Qemu-devel] [PATCH v1 6/8] docker: docker.py don't conflate checksums for extra_files Philippe Mathieu-Daudé
2018-06-18 13:07 ` [Qemu-devel] [PATCH v1 7/8] docker: docker.py add check sub-command Alex Bennée
2018-06-18 13:07 ` [Qemu-devel] [PATCH v1 8/8] docker: docker.py adding age check command Alex Bennée
2018-06-18 16:06 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618130709.19730-7-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=balrogg@gmail.com \
--cc=berrange@redhat.com \
--cc=cota@braap.org \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).