qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Jeff Cody <jcody@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Iliya Dyachenko <gandalfthewhite@mail.ru>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] enabling smart-http git protocol on git.qemu.org
Date: Mon, 18 Jun 2018 15:02:43 +0100	[thread overview]
Message-ID: <20180618140243.GI3589@redhat.com> (raw)
In-Reply-To: <20180618135410.GA18383@localhost.localdomain>

On Mon, Jun 18, 2018 at 09:54:10AM -0400, Jeff Cody wrote:
> On Mon, Jun 18, 2018 at 11:55:05AM +0100, Peter Maydell wrote:
> > On 18 June 2018 at 10:47, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > > On Mon, Jun 18, 2018 at 12:32:01PM +0300, Iliya Dyachenko wrote:
> > >> Signed-off-by: Iliya Dyachenko <gandalfthewhite@mail.ru>
> > >> ---
> > >>  .gitmodules | 32 ++++++++++++++++----------------
> > >>  1 file changed, 16 insertions(+), 16 deletions(-)
> > >>
> > >> diff --git a/.gitmodules b/.gitmodules
> > >> index 49e9c2e3f4..e6bc732d16 100644
> > >> --- a/.gitmodules
> > >> +++ b/.gitmodules
> > >> @@ -1,48 +1,48 @@
> > >>  [submodule "roms/vgabios"]
> > >>       path = roms/vgabios
> > >> -     url = git://git.qemu-project.org/vgabios.git/
> > >> +     url = https://git.qemu.org/git/vgabios.git
> > >
> > > [snip]
> > >
> > > This is highly desirable, however, we cannot do it right now.
> > >
> > > The git.qemu.org server is still using the dumb git http protocol, so it
> > > would be a performance regression over git://
> > >
> > > We need the server config fixing to use the smart http protocol.
> > >
> > > Essentially this just involves configuring apache to add
> > >
> > >   <Directory /usr/libexec/git-core>
> > >     Allow from all
> > >   </Directory>
> > >
> > >   SetEnv GIT_PROJECT_ROOT /data/git
> > >
> > >   ScriptAliasMatch "^/git/(.*\.git/(HEAD|info/refs))$" \
> > >     /usr/libexec/git-core/git-http-backend/$1
> > >   ScriptAliasMatch "^/git/(.*\.git/git-(upload|receive)-pack)$" \
> > >     /usr/libexec/git-core/git-http-backend/$1
> > 
> > Sounds like a good idea -- I've cc'd Jeff and Stefan (who
> > are the people who care for our git server)...
> >
> 
> Thanks, it is a good idea.  I think Peter also brought this up once before,
> if I am not mistaken.  I'll work on implementing that today.

To check it is working correctly once configured, use the following:

  $ curl -si https://git.qemu.org/git/capstone.git/info/refs?service=git-upload-pack | grep --binary-files=text '^Content-Type'


Once configured correctly that should display:

   Content-Type: application/x-git-upload-pack-advertisement

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

      reply	other threads:[~2018-06-18 14:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-18 10:55 [Qemu-devel] enabling smart-http git protocol on git.qemu.org Peter Maydell
2018-06-18 11:26 ` Gerd Hoffmann
2018-06-18 14:01   ` Jeff Cody
2018-06-18 13:54 ` Jeff Cody
2018-06-18 14:02   ` Daniel P. Berrangé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180618140243.GI3589@redhat.com \
    --to=berrange@redhat.com \
    --cc=gandalfthewhite@mail.ru \
    --cc=jcody@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).