[Qemu-devel] enabling smart-http git protocol on git.qemu.org

[Qemu-devel] enabling smart-http git protocol on git.qemu.org

[Peter Maydell]

On 18 June 2018 at 10:47, Daniel P. Berrangé <berrange@redhat.com> wrote:
> On Mon, Jun 18, 2018 at 12:32:01PM +0300, Iliya Dyachenko wrote:
>> Signed-off-by: Iliya Dyachenko <gandalfthewhite@mail.ru>
>> ---
>>  .gitmodules | 32 ++++++++++++++++----------------
>>  1 file changed, 16 insertions(+), 16 deletions(-)
>>
>> diff --git a/.gitmodules b/.gitmodules
>> index 49e9c2e3f4..e6bc732d16 100644
>> --- a/.gitmodules
>> +++ b/.gitmodules
>> @@ -1,48 +1,48 @@
>>  [submodule "roms/vgabios"]
>>       path = roms/vgabios
>> -     url = git://git.qemu-project.org/vgabios.git/
>> +     url = https://git.qemu.org/git/vgabios.git
>
> [snip]
>
> This is highly desirable, however, we cannot do it right now.
>
> The git.qemu.org server is still using the dumb git http protocol, so it
> would be a performance regression over git://
>
> We need the server config fixing to use the smart http protocol.
>
> Essentially this just involves configuring apache to add
>
>   <Directory /usr/libexec/git-core>
>     Allow from all
>   </Directory>
>
>   SetEnv GIT_PROJECT_ROOT /data/git
>
>   ScriptAliasMatch "^/git/(.*\.git/(HEAD|info/refs))$" \
>     /usr/libexec/git-core/git-http-backend/$1
>   ScriptAliasMatch "^/git/(.*\.git/git-(upload|receive)-pack)$" \
>     /usr/libexec/git-core/git-http-backend/$1

Sounds like a good idea -- I've cc'd Jeff and Stefan (who
are the people who care for our git server)...

thanks
-- PMM

Re: [Qemu-devel] enabling smart-http git protocol on git.qemu.org

[Gerd Hoffmann]

  Hi,

> >   ScriptAliasMatch "^/git/(.*\.git/(HEAD|info/refs))$" \
> >     /usr/libexec/git-core/git-http-backend/$1
> >   ScriptAliasMatch "^/git/(.*\.git/git-(upload|receive)-pack)$" \
> >     /usr/libexec/git-core/git-http-backend/$1
> 
> Sounds like a good idea -- I've cc'd Jeff and Stefan (who
> are the people who care for our git server)...

While being at it: seabios git url has changed, can the mirror be
updated please?  New URL is:

https://git.seabios.org/seabios.git

thanks,
  Gerd

Re: [Qemu-devel] enabling smart-http git protocol on git.qemu.org

[Jeff Cody]

On Mon, Jun 18, 2018 at 11:55:05AM +0100, Peter Maydell wrote:
> On 18 June 2018 at 10:47, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > On Mon, Jun 18, 2018 at 12:32:01PM +0300, Iliya Dyachenko wrote:
> >> Signed-off-by: Iliya Dyachenko <gandalfthewhite@mail.ru>
> >> ---
> >>  .gitmodules | 32 ++++++++++++++++----------------
> >>  1 file changed, 16 insertions(+), 16 deletions(-)
> >>
> >> diff --git a/.gitmodules b/.gitmodules
> >> index 49e9c2e3f4..e6bc732d16 100644
> >> --- a/.gitmodules
> >> +++ b/.gitmodules
> >> @@ -1,48 +1,48 @@
> >>  [submodule "roms/vgabios"]
> >>       path = roms/vgabios
> >> -     url = git://git.qemu-project.org/vgabios.git/
> >> +     url = https://git.qemu.org/git/vgabios.git
> >
> > [snip]
> >
> > This is highly desirable, however, we cannot do it right now.
> >
> > The git.qemu.org server is still using the dumb git http protocol, so it
> > would be a performance regression over git://
> >
> > We need the server config fixing to use the smart http protocol.
> >
> > Essentially this just involves configuring apache to add
> >
> >   <Directory /usr/libexec/git-core>
> >     Allow from all
> >   </Directory>
> >
> >   SetEnv GIT_PROJECT_ROOT /data/git
> >
> >   ScriptAliasMatch "^/git/(.*\.git/(HEAD|info/refs))$" \
> >     /usr/libexec/git-core/git-http-backend/$1
> >   ScriptAliasMatch "^/git/(.*\.git/git-(upload|receive)-pack)$" \
> >     /usr/libexec/git-core/git-http-backend/$1
> 
> Sounds like a good idea -- I've cc'd Jeff and Stefan (who
> are the people who care for our git server)...
>

Thanks, it is a good idea.  I think Peter also brought this up once before,
if I am not mistaken.  I'll work on implementing that today.

-Jeff

Re: [Qemu-devel] enabling smart-http git protocol on git.qemu.org

[Jeff Cody]

On Mon, Jun 18, 2018 at 01:26:22PM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > >   ScriptAliasMatch "^/git/(.*\.git/(HEAD|info/refs))$" \
> > >     /usr/libexec/git-core/git-http-backend/$1
> > >   ScriptAliasMatch "^/git/(.*\.git/git-(upload|receive)-pack)$" \
> > >     /usr/libexec/git-core/git-http-backend/$1
> > 
> > Sounds like a good idea -- I've cc'd Jeff and Stefan (who
> > are the people who care for our git server)...
> 
> While being at it: seabios git url has changed, can the mirror be
> updated please?  New URL is:
> 
> https://git.seabios.org/seabios.git
> 
> thanks,
>   Gerd
> 

Thanks Gerd.

The seabios upstream url has been updated.  Let me know if there are any
issues.


-Jeff

Re: [Qemu-devel] enabling smart-http git protocol on git.qemu.org

[Daniel P. Berrangé]

On Mon, Jun 18, 2018 at 09:54:10AM -0400, Jeff Cody wrote:
> On Mon, Jun 18, 2018 at 11:55:05AM +0100, Peter Maydell wrote:
> > On 18 June 2018 at 10:47, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > > On Mon, Jun 18, 2018 at 12:32:01PM +0300, Iliya Dyachenko wrote:
> > >> Signed-off-by: Iliya Dyachenko <gandalfthewhite@mail.ru>
> > >> ---
> > >>  .gitmodules | 32 ++++++++++++++++----------------
> > >>  1 file changed, 16 insertions(+), 16 deletions(-)
> > >>
> > >> diff --git a/.gitmodules b/.gitmodules
> > >> index 49e9c2e3f4..e6bc732d16 100644
> > >> --- a/.gitmodules
> > >> +++ b/.gitmodules
> > >> @@ -1,48 +1,48 @@
> > >>  [submodule "roms/vgabios"]
> > >>       path = roms/vgabios
> > >> -     url = git://git.qemu-project.org/vgabios.git/
> > >> +     url = https://git.qemu.org/git/vgabios.git
> > >
> > > [snip]
> > >
> > > This is highly desirable, however, we cannot do it right now.
> > >
> > > The git.qemu.org server is still using the dumb git http protocol, so it
> > > would be a performance regression over git://
> > >
> > > We need the server config fixing to use the smart http protocol.
> > >
> > > Essentially this just involves configuring apache to add
> > >
> > >   <Directory /usr/libexec/git-core>
> > >     Allow from all
> > >   </Directory>
> > >
> > >   SetEnv GIT_PROJECT_ROOT /data/git
> > >
> > >   ScriptAliasMatch "^/git/(.*\.git/(HEAD|info/refs))$" \
> > >     /usr/libexec/git-core/git-http-backend/$1
> > >   ScriptAliasMatch "^/git/(.*\.git/git-(upload|receive)-pack)$" \
> > >     /usr/libexec/git-core/git-http-backend/$1
> > 
> > Sounds like a good idea -- I've cc'd Jeff and Stefan (who
> > are the people who care for our git server)...
> >
> 
> Thanks, it is a good idea.  I think Peter also brought this up once before,
> if I am not mistaken.  I'll work on implementing that today.

To check it is working correctly once configured, use the following:

  $ curl -si https://git.qemu.org/git/capstone.git/info/refs?service=git-upload-pack | grep --binary-files=text '^Content-Type'


Once configured correctly that should display:

   Content-Type: application/x-git-upload-pack-advertisement

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|