From: Amol Surati <suratiamol@gmail.com>
To: John Snow <jsnow@redhat.com>
Cc: Amol Surati <suratiamol@gmail.com>,
qemu-devel@nongnu.org, "open list:IDE" <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes
Date: Mon, 18 Jun 2018 23:54:53 +0530 [thread overview]
Message-ID: <20180618182451.GA3610@arch> (raw)
In-Reply-To: <7b876b98-527d-f158-441b-5004b6bcd3a9@redhat.com>
On Mon, Jun 18, 2018 at 02:13:52PM -0400, John Snow wrote:
>
> On 06/18/2018 02:02 PM, Amol Surati wrote:
> > On Mon, Jun 18, 2018 at 12:05:15AM +0530, Amol Surati wrote:
> >> This patch fixes the assumption that io_buffer_size is always a perfect
> >> multiple of the sector size. The assumption is the cause of the firing
> >> of 'assert(n * 512 == s->sg.size);'.
> >>
> >> Signed-off-by: Amol Surati <suratiamol@gmail.com>
> >> ---
> >
> > The repository https://github.com/asurati/1777315 contains a module for
> > QEMU's 8086:7010 ATA controller, which exercises the code path
> > described in [RFC 0/1] of this series.
> >
> > Loading the module reproduces the bug. Tested on the latest master
> > branch.
> >
> > Steps:
. . .
. . .
> Are you the original reporter as well?
I am not the original reporter.
> I'm looking at the patch and the reproducer now, thanks.
>
> --js
-Amol
next prev parent reply other threads:[~2018-06-18 18:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-17 18:35 [Qemu-devel] [RFC 0/1] ide: attempt at fixing the bug #1777315 Amol Surati
2018-06-17 18:35 ` [Qemu-devel] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes Amol Surati
2018-06-18 18:02 ` Amol Surati
2018-06-18 18:13 ` John Snow
2018-06-18 18:24 ` Amol Surati [this message]
2018-06-19 0:14 ` John Snow
2018-06-19 4:01 ` Amol Surati
2018-06-19 8:53 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2018-06-19 13:45 ` John Snow
2018-06-19 14:34 ` Amol Surati
2018-06-19 21:26 ` Amol Surati
2018-06-19 21:43 ` John Snow
2018-06-20 0:53 ` Amol Surati
2018-06-20 1:27 ` Amol Surati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618182451.GA3610@arch \
--to=suratiamol@gmail.com \
--cc=jsnow@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).