From: Wei Xu <wexu@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: jfreimann@redhat.com, qemu-devel@nongnu.org, tiwei.bie@intel.com,
mst@redhat.com
Subject: Re: [Qemu-devel] [RFC v2 5/8] virtio: queue pop for packed ring
Date: Tue, 19 Jun 2018 15:58:08 +0800 [thread overview]
Message-ID: <20180619075808.GB23983@wei-ubt> (raw)
In-Reply-To: <04a61e4a-f0ae-0e7d-03aa-c488e89fd1ca@redhat.com>
On Wed, Jun 06, 2018 at 11:41:18AM +0800, Jason Wang wrote:
>
>
> On 2018年06月06日 11:38, Wei Xu wrote:
> >>>+
> >>>+ head = vq->last_avail_idx;
> >>>+ i = head;
> >>>+
> >>>+ caches = vring_get_region_caches(vq);
> >>>+ cache = &caches->desc;
> >>>+ vring_packed_desc_read(vdev, &desc, cache, i);
> >>I think we'd better find a way to avoid reading descriptor twice.
> >Do you mean here and the read for empty check?
> >
> >Wei
> >
>
> Yes.
OK, will figure it out.
>
> Thanks
>
>
next prev parent reply other threads:[~2018-06-19 7:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 19:07 [Qemu-devel] [RFC v2 0/8] packed ring virtio-net userspace backend support wexu
2018-06-05 19:07 ` [Qemu-devel] [RFC v2 1/8] virtio: feature bit, data structure, init for 1.1 wexu
2018-06-06 2:49 ` Jason Wang
2018-06-05 19:07 ` [Qemu-devel] [RFC v2 2/8] virtio: memory cache for packed ring wexu
2018-06-06 2:53 ` Jason Wang
2018-06-19 7:39 ` Wei Xu
2018-06-13 12:27 ` Paolo Bonzini
2018-06-05 19:07 ` [Qemu-devel] [RFC v2 3/8] virtio: empty check and desc read " wexu
2018-06-06 3:09 ` Jason Wang
2018-06-05 19:07 ` [Qemu-devel] [RFC v2 4/8] virtio: get avail bytes check " wexu
2018-06-06 3:19 ` Jason Wang
2018-06-05 19:08 ` [Qemu-devel] [RFC v2 5/8] virtio: queue pop " wexu
2018-06-06 3:29 ` Jason Wang
2018-06-06 3:38 ` Wei Xu
2018-06-06 3:41 ` Jason Wang
2018-06-19 7:58 ` Wei Xu [this message]
2018-06-05 19:08 ` [Qemu-devel] [RFC v2 6/8] virtio: flush/push " wexu
2018-06-06 3:39 ` Jason Wang
[not found] ` <7dc2af60-47ad-1250-fc6c-3fdf288654c3@redhat.com>
2018-11-28 17:33 ` Maxime Coquelin
2018-06-05 19:08 ` [Qemu-devel] [RFC v2 7/8] virtio: event suppression " wexu
2018-06-06 3:46 ` Jason Wang
2018-06-05 19:08 ` [Qemu-devel] [RFC v2 8/8] virtio: guest driver reload for vhost-net wexu
2018-06-06 3:48 ` Jason Wang
2018-06-19 7:53 ` Wei Xu
2018-06-06 2:34 ` [Qemu-devel] [RFC v2 0/8] packed ring virtio-net userspace backend support Jason Wang
2018-06-06 3:49 ` Jason Wang
2018-06-19 7:41 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180619075808.GB23983@wei-ubt \
--to=wexu@redhat.com \
--cc=jasowang@redhat.com \
--cc=jfreimann@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tiwei.bie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).