From: David Hildenbrand <david@redhat.com>
To: qemu-s390x@nongnu.org
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>,
Alexander Graf <agraf@suse.de>, Cornelia Huck <cohuck@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>
Subject: [Qemu-devel] [PATCH v2 0/7] s390x: TOD refactoring + TCG CPU hotplug support
Date: Wed, 20 Jun 2018 12:08:18 +0200 [thread overview]
Message-ID: <20180620100825.22476-1-david@redhat.com> (raw)
The TOD in TCG is not handled correctly:
- each CPU has its own TOD based on CPU creation time vs. a system TOD
- TOD is not migrated
- TOD timer is not restarted during migration
- CKC interrupts/TOD timer is not cleared when resetting the CKC
This (and a cpu creation problem for single threaded TCG) currently made
CPU hotplug under TCG not work. Now it's working
The fist patch also refactors TOD handling for KVM (moved into a new
TOD device).
v1 -> v2:
- "s390x/tcg: properly implement the TOD"
-- introduce "tcg_s390x.h" similar to "kvm_s390x.h"
-- dropped one unnecessary include introduction
- "s390x/tcg: rearm the CKC timer during migration"
-- introduce "tcg-stub.c" similar to "kvm-stub.c"
David Hildenbrand (7):
s390x/tod: factor out TOD into separate device
s390x/tcg: drop tod_basetime
s390x/tcg: properly implement the TOD
s390x/tcg: SET CLOCK COMPARATOR can clear CKC interrupts
s390x/tcg: implement SET CLOCK
s390x/tcg: rearm the CKC timer during migration
s390x/tcg: fix CPU hotplug with single-threaded TCG
hw/s390x/Makefile.objs | 3 +
hw/s390x/s390-virtio-ccw.c | 57 +---------------
hw/s390x/tod-kvm.c | 64 ++++++++++++++++++
hw/s390x/tod-qemu.c | 85 ++++++++++++++++++++++++
hw/s390x/tod.c | 131 +++++++++++++++++++++++++++++++++++++
include/hw/s390x/tod.h | 65 ++++++++++++++++++
target/s390x/Makefile.objs | 1 +
target/s390x/cpu.c | 51 ++-------------
target/s390x/cpu.h | 4 --
target/s390x/helper.h | 1 +
target/s390x/insn-data.def | 3 +-
target/s390x/internal.h | 15 -----
target/s390x/kvm_s390x.h | 2 +
target/s390x/machine.c | 6 ++
target/s390x/misc_helper.c | 60 +++++++++++++++--
target/s390x/tcg-stub.c | 20 ++++++
target/s390x/tcg_s390x.h | 18 +++++
target/s390x/translate.c | 9 +++
18 files changed, 468 insertions(+), 127 deletions(-)
create mode 100644 hw/s390x/tod-kvm.c
create mode 100644 hw/s390x/tod-qemu.c
create mode 100644 hw/s390x/tod.c
create mode 100644 include/hw/s390x/tod.h
create mode 100644 target/s390x/tcg-stub.c
create mode 100644 target/s390x/tcg_s390x.h
--
2.17.1
next reply other threads:[~2018-06-20 10:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 10:08 David Hildenbrand [this message]
2018-06-20 10:08 ` [Qemu-devel] [PATCH v2 1/7] s390x/tod: factor out TOD into separate device David Hildenbrand
2018-06-21 11:15 ` Thomas Huth
2018-06-21 11:51 ` David Hildenbrand
2018-06-20 10:08 ` [Qemu-devel] [PATCH v2 2/7] s390x/tcg: drop tod_basetime David Hildenbrand
2018-06-21 11:33 ` Thomas Huth
2018-06-20 10:08 ` [Qemu-devel] [PATCH v2 3/7] s390x/tcg: properly implement the TOD David Hildenbrand
2018-06-20 19:33 ` Richard Henderson
2018-06-20 20:33 ` David Hildenbrand
2018-06-20 21:00 ` Richard Henderson
2018-06-21 11:44 ` Thomas Huth
2018-06-21 11:52 ` David Hildenbrand
2018-06-20 10:08 ` [Qemu-devel] [PATCH v2 4/7] s390x/tcg: SET CLOCK COMPARATOR can clear CKC interrupts David Hildenbrand
2018-06-21 12:09 ` Thomas Huth
2018-06-21 13:54 ` David Hildenbrand
2018-06-21 14:01 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-06-21 14:10 ` [Qemu-devel] " Cornelia Huck
2018-06-21 13:58 ` Cornelia Huck
2018-06-21 14:03 ` David Hildenbrand
2018-06-20 10:08 ` [Qemu-devel] [PATCH v2 5/7] s390x/tcg: implement SET CLOCK David Hildenbrand
2018-06-21 13:14 ` Thomas Huth
2018-06-21 14:01 ` David Hildenbrand
2018-06-21 14:23 ` Cornelia Huck
2018-06-20 10:08 ` [Qemu-devel] [PATCH v2 6/7] s390x/tcg: rearm the CKC timer during migration David Hildenbrand
2018-06-21 13:18 ` Thomas Huth
2018-06-20 10:08 ` [Qemu-devel] [PATCH v2 7/7] s390x/tcg: fix CPU hotplug with single-threaded TCG David Hildenbrand
2018-06-21 13:22 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620100825.22476-1-david@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).