From: David Hildenbrand <david@redhat.com>
To: qemu-s390x@nongnu.org
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>,
Alexander Graf <agraf@suse.de>, Cornelia Huck <cohuck@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>
Subject: [Qemu-devel] [PATCH v2 6/7] s390x/tcg: rearm the CKC timer during migration
Date: Wed, 20 Jun 2018 12:08:24 +0200 [thread overview]
Message-ID: <20180620100825.22476-7-david@redhat.com> (raw)
In-Reply-To: <20180620100825.22476-1-david@redhat.com>
If the CPU data is migrated after the TOD clock, the CKC timer of a CPU
is not rearmed. Let's rearm it when loading the CPU state.
Introduce tcg-stub.c just like kvm-stub.c for tcg specific stubs.
Signed-off-by: David Hildenbrand <david@redhat.com>
---
target/s390x/Makefile.objs | 1 +
target/s390x/machine.c | 6 ++++++
target/s390x/tcg-stub.c | 20 ++++++++++++++++++++
3 files changed, 27 insertions(+)
create mode 100644 target/s390x/tcg-stub.c
diff --git a/target/s390x/Makefile.objs b/target/s390x/Makefile.objs
index 31932de9cf..22a9a9927a 100644
--- a/target/s390x/Makefile.objs
+++ b/target/s390x/Makefile.objs
@@ -5,6 +5,7 @@ obj-$(CONFIG_SOFTMMU) += machine.o ioinst.o arch_dump.o mmu_helper.o diag.o
obj-$(CONFIG_SOFTMMU) += sigp.o
obj-$(CONFIG_KVM) += kvm.o
obj-$(call lnot,$(CONFIG_KVM)) += kvm-stub.o
+obj-$(call lnot,$(CONFIG_TCG)) += tcg-stub.o
# build and run feature list generator
feat-src = $(SRC_PATH)/target/$(TARGET_BASE_ARCH)/
diff --git a/target/s390x/machine.c b/target/s390x/machine.c
index 84b4928755..bd3230d027 100644
--- a/target/s390x/machine.c
+++ b/target/s390x/machine.c
@@ -19,6 +19,7 @@
#include "cpu.h"
#include "internal.h"
#include "kvm_s390x.h"
+#include "tcg_s390x.h"
#include "sysemu/kvm.h"
static int cpu_post_load(void *opaque, int version_id)
@@ -34,6 +35,11 @@ static int cpu_post_load(void *opaque, int version_id)
return kvm_s390_vcpu_interrupt_post_load(cpu);
}
+ if (tcg_enabled()) {
+ /* Rearm the CKC timer if necessary */
+ tcg_s390_tod_updated(CPU(cpu), RUN_ON_CPU_NULL);
+ }
+
return 0;
}
diff --git a/target/s390x/tcg-stub.c b/target/s390x/tcg-stub.c
new file mode 100644
index 0000000000..c93501db0b
--- /dev/null
+++ b/target/s390x/tcg-stub.c
@@ -0,0 +1,20 @@
+/*
+ * QEMU TCG support -- s390x specific function stubs.
+ *
+ * Copyright (C) 2018 Red Hat Inc
+ *
+ * Authors:
+ * David Hildenbrand <david@redhat.com>
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ */
+
+#include "qemu/osdep.h"
+#include "qemu-common.h"
+#include "cpu.h"
+#include "tcg_s390x.h"
+
+void tcg_s390_tod_updated(CPUState *cs, run_on_cpu_data opaque)
+{
+}
--
2.17.1
next prev parent reply other threads:[~2018-06-20 10:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 10:08 [Qemu-devel] [PATCH v2 0/7] s390x: TOD refactoring + TCG CPU hotplug support David Hildenbrand
2018-06-20 10:08 ` [Qemu-devel] [PATCH v2 1/7] s390x/tod: factor out TOD into separate device David Hildenbrand
2018-06-21 11:15 ` Thomas Huth
2018-06-21 11:51 ` David Hildenbrand
2018-06-20 10:08 ` [Qemu-devel] [PATCH v2 2/7] s390x/tcg: drop tod_basetime David Hildenbrand
2018-06-21 11:33 ` Thomas Huth
2018-06-20 10:08 ` [Qemu-devel] [PATCH v2 3/7] s390x/tcg: properly implement the TOD David Hildenbrand
2018-06-20 19:33 ` Richard Henderson
2018-06-20 20:33 ` David Hildenbrand
2018-06-20 21:00 ` Richard Henderson
2018-06-21 11:44 ` Thomas Huth
2018-06-21 11:52 ` David Hildenbrand
2018-06-20 10:08 ` [Qemu-devel] [PATCH v2 4/7] s390x/tcg: SET CLOCK COMPARATOR can clear CKC interrupts David Hildenbrand
2018-06-21 12:09 ` Thomas Huth
2018-06-21 13:54 ` David Hildenbrand
2018-06-21 14:01 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-06-21 14:10 ` [Qemu-devel] " Cornelia Huck
2018-06-21 13:58 ` Cornelia Huck
2018-06-21 14:03 ` David Hildenbrand
2018-06-20 10:08 ` [Qemu-devel] [PATCH v2 5/7] s390x/tcg: implement SET CLOCK David Hildenbrand
2018-06-21 13:14 ` Thomas Huth
2018-06-21 14:01 ` David Hildenbrand
2018-06-21 14:23 ` Cornelia Huck
2018-06-20 10:08 ` David Hildenbrand [this message]
2018-06-21 13:18 ` [Qemu-devel] [PATCH v2 6/7] s390x/tcg: rearm the CKC timer during migration Thomas Huth
2018-06-20 10:08 ` [Qemu-devel] [PATCH v2 7/7] s390x/tcg: fix CPU hotplug with single-threaded TCG David Hildenbrand
2018-06-21 13:22 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620100825.22476-7-david@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).