From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Roman Kagan" <rkagan@virtuozzo.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org, "Eduardo Habkost" <ehabkost@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 0/3] i386: fix handling of multiboot modules
Date: Wed, 20 Jun 2018 18:34:26 +0300 [thread overview]
Message-ID: <20180620183313-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180620145756.GB5385@rkaganb.sw.ru>
On Wed, Jun 20, 2018 at 05:57:56PM +0300, Roman Kagan wrote:
> On Mon, May 14, 2018 at 06:19:10PM +0100, Daniel P. Berrangé wrote:
> > This short series fixes a flaw identified by coverity which broke the
> > handling of multiboot modules.
>
> This flaw also makes QEMU segfault when running kvm-unit-tests, and the
> series fixes it.
>
> So
>
> Tested-by: Roman Kagan <rkagan@virtuozzo.com>
>
> Wondering if anyone else runs kvm-unit-tests with QEMU master,
> Roman.
It might be a good idea to make it a submodule, and
use it for unit tests. I'll take a look.
> >
> > Daniel P. Berrangé (3):
> > i386: fix regression parsing multiboot initrd modules
> > i386: only parse the initrd_filename once for multiboot modules
> > opts: remove redundant check for NULL parameter
> >
> > hw/i386/multiboot.c | 35 ++++++++++++++++-------------------
> > util/qemu-option.c | 8 +++-----
> > 2 files changed, 19 insertions(+), 24 deletions(-)
> >
> > --
> > 2.17.0
> >
> >
prev parent reply other threads:[~2018-06-20 15:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 17:19 [Qemu-devel] [PATCH 0/3] i386: fix handling of multiboot modules Daniel P. Berrangé
2018-05-14 17:19 ` [Qemu-devel] [PATCH 1/3] i386: fix regression parsing multiboot initrd modules Daniel P. Berrangé
2018-05-18 17:54 ` Peter Maydell
2018-05-21 8:56 ` Daniel P. Berrangé
2018-07-16 21:23 ` Eduardo Habkost
2018-05-14 17:19 ` [Qemu-devel] [PATCH 2/3] i386: only parse the initrd_filename once for multiboot modules Daniel P. Berrangé
2018-07-16 21:28 ` Eduardo Habkost
2018-05-14 17:19 ` [Qemu-devel] [PATCH 3/3] opts: remove redundant check for NULL parameter Daniel P. Berrangé
2018-07-16 21:28 ` Eduardo Habkost
2018-06-07 9:47 ` [Qemu-devel] [PATCH 0/3] i386: fix handling of multiboot modules Daniel P. Berrangé
2018-07-10 17:11 ` Roman Kagan
2018-07-10 17:23 ` Eduardo Habkost
2018-08-16 14:34 ` Roman Kagan
2018-08-16 14:38 ` Daniel P. Berrangé
2018-08-16 14:41 ` Roman Kagan
2018-06-20 14:57 ` Roman Kagan
2018-06-20 15:34 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620183313-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkagan@virtuozzo.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).