From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVxxY-0000Hp-2P for qemu-devel@nongnu.org; Thu, 21 Jun 2018 07:41:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVxxU-0004Tm-UD for qemu-devel@nongnu.org; Thu, 21 Jun 2018 07:41:04 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:33360 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fVxxU-0004TX-PI for qemu-devel@nongnu.org; Thu, 21 Jun 2018 07:41:00 -0400 Date: Thu, 21 Jun 2018 12:40:57 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180621114057.GI3615@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20180621083551.775-1-armbru@redhat.com> <20180621091831.GF3615@redhat.com> <877emso01o.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <877emso01o.fsf@dusky.pond.sub.org> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qapi: Fix some pycodestyle-3 complaints List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com On Thu, Jun 21, 2018 at 01:23:47PM +0200, Markus Armbruster wrote: > Daniel P. Berrang=C3=A9 writes: >=20 > > On Thu, Jun 21, 2018 at 10:35:51AM +0200, Markus Armbruster wrote: > >> Fix the following issues: > >>=20 > >> common.py:873:13: E129 visually indented line with same indent a= s next logical line > >> common.py:1766:5: E741 ambiguous variable name 'l' > >> common.py:1784:1: E305 expected 2 blank lines after class or fun= ction definition, found 1 > >> common.py:1833:1: E305 expected 2 blank lines after class or fun= ction definition, found 1 > >> common.py:1843:1: E305 expected 2 blank lines after class or fun= ction definition, found 1 > >> visit.py:181:18: E127 continuation line over-indented for visual= indent > >>=20 > >> Signed-off-by: Markus Armbruster > >> --- > >> scripts/qapi/common.py | 15 +++++++++------ > >> scripts/qapi/visit.py | 2 +- > >> 2 files changed, 10 insertions(+), 7 deletions(-) > > > > Reviewed-by: Daniel P. Berrang=C3=A9 > > > > > > If we care about pycodestyle-3 compliance, it is probably worth addin= g > > that to 'make check' to avoid people introducing regressions. >=20 > It's not spotless, yet: >=20 > $ pycodestyle-3 scripts/qapi-gen.py scripts/qapi/*.py > scripts/qapi/commands.py:66:80: E501 line too long (93 > 79 characters) > scripts/qapi/common.py:818:49: E261 at least two spaces before inline c= omment > scripts/qapi/visit.py:24:80: E501 line too long (86 > 79 characters) > scripts/qapi/visit.py:117:80: E501 line too long (88 > 79 characters) > scripts/qapi/visit.py:154:80: E501 line too long (87 > 79 characters) > scripts/qapi/visit.py:167:80: E501 line too long (88 > 79 characters) > scripts/qapi/visit.py:237:80: E501 line too long (88 > 79 characters) >=20 > The long lines are in mcgen() arguments. >=20 > If cleaning these up is the price for automation, I guess we'll pay it. FWIW, --select=3DXXX or --ignore=3DXXX args let you turn off classes of w= arning we don't wish to fix. Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|