From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, imammedo@redhat.com,
sjitindarsingh@gmail.com, walling@linux.ibm.com
Cc: armbru@redhat.com
Subject: [Qemu-devel] [PULL 5/9] hmp: Restrict auto-complete in preconfig
Date: Thu, 21 Jun 2018 17:47:23 +0100 [thread overview]
Message-ID: <20180621164727.36626-6-dgilbert@redhat.com> (raw)
In-Reply-To: <20180621164727.36626-1-dgilbert@redhat.com>
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Don't show the commands that aren't available.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20180620153947.30834-4-dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
monitor.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/monitor.c b/monitor.c
index 18c2207e6d..068c094a9a 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4020,12 +4020,17 @@ static void monitor_find_completion_by_table(Monitor *mon,
cmdname = args[0];
readline_set_completion_index(mon->rs, strlen(cmdname));
for (cmd = cmd_table; cmd->name != NULL; cmd++) {
- cmd_completion(mon, cmdname, cmd->name);
+ if (!runstate_check(RUN_STATE_PRECONFIG) ||
+ cmd_can_preconfig(cmd)) {
+ cmd_completion(mon, cmdname, cmd->name);
+ }
}
} else {
/* find the command */
for (cmd = cmd_table; cmd->name != NULL; cmd++) {
- if (compare_cmd(args[0], cmd->name)) {
+ if (compare_cmd(args[0], cmd->name) &&
+ (!runstate_check(RUN_STATE_PRECONFIG) ||
+ cmd_can_preconfig(cmd))) {
break;
}
}
--
2.17.1
next prev parent reply other threads:[~2018-06-21 16:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 16:47 [Qemu-devel] [PULL 0/9] hmp queue Dr. David Alan Gilbert (git)
2018-06-21 16:47 ` [Qemu-devel] [PULL 1/9] monitor: report entirety of hmp command on error Dr. David Alan Gilbert (git)
2018-06-21 16:47 ` [Qemu-devel] [PULL 2/9] hmp-commands: use long for begin and length in dump-guest-memory Dr. David Alan Gilbert (git)
2018-06-21 16:47 ` [Qemu-devel] [PULL 3/9] hmp: Add flag for preconfig commands Dr. David Alan Gilbert (git)
2018-06-21 16:47 ` [Qemu-devel] [PULL 4/9] hmp: Allow help on " Dr. David Alan Gilbert (git)
2018-06-21 16:47 ` Dr. David Alan Gilbert (git) [this message]
2018-06-21 16:47 ` [Qemu-devel] [PULL 6/9] qmp: Enable a few commands in preconfig state Dr. David Alan Gilbert (git)
2018-06-21 16:47 ` [Qemu-devel] [PULL 7/9] hmp: Add commands for preconfig Dr. David Alan Gilbert (git)
2018-06-21 16:47 ` [Qemu-devel] [PULL 8/9] hmp: add exit_preconfig Dr. David Alan Gilbert (git)
2018-06-21 16:47 ` [Qemu-devel] [PULL 9/9] hmp: Allow HMP in preconfig state again Dr. David Alan Gilbert (git)
2018-06-22 13:18 ` [Qemu-devel] [PULL 0/9] hmp queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180621164727.36626-6-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sjitindarsingh@gmail.com \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).