qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Siwei Liu <loseweigh@gmail.com>,
	"Samudrala, Sridhar" <sridhar.samudrala@intel.com>,
	Alexander Duyck <alexander.h.duyck@intel.com>,
	virtio-dev@lists.oasis-open.org, aaron.f.brown@intel.com,
	Jiri Pirko <jiri@resnulli.us>, Jakub Kicinski <kubakici@wp.pl>,
	Netdev <netdev@vger.kernel.org>,
	qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org,
	konrad.wilk@oracle.com, boris.ostrovsky@oracle.com,
	Joao Martins <joao.m.martins@oracle.com>,
	Venu Busireddy <venu.busireddy@oracle.com>,
	vijay.balakrishna@oracle.com
Subject: Re: [Qemu-devel] [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net
Date: Thu, 21 Jun 2018 21:20:13 +0300	[thread overview]
Message-ID: <20180621211712-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180621165913.7e3f4faa.cohuck@redhat.com>

On Thu, Jun 21, 2018 at 04:59:13PM +0200, Cornelia Huck wrote:
> On Wed, 20 Jun 2018 22:48:58 +0300
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
> > On Wed, Jun 20, 2018 at 06:06:19PM +0200, Cornelia Huck wrote:
> > > In any case, I'm not sure anymore why we'd want the extra uuid.  
> > 
> > It's mostly so we can have e.g. multiple devices with same MAC
> > (which some people seem to want in order to then use
> > then with different containers).
> > 
> > But it is also handy for when you assign a PF, since then you
> > can't set the MAC.
> > 
> 
> OK, so what about the following:
> 
> - introduce a new feature bit, VIRTIO_NET_F_STANDBY_UUID that indicates
>   that we have a new uuid field in the virtio-net config space
> - in QEMU, add a property for virtio-net that allows to specify a uuid,
>   offer VIRTIO_NET_F_STANDBY_UUID if set
> - when configuring, set the property to the group UUID of the vfio-pci
>   device
> - in the guest, use the uuid from the virtio-net device's config space
>   if applicable; else, fall back to matching by MAC as done today
> 
> That should work for all virtio transports.

True. I'm a bit unhappy that it's virtio net specific though
since down the road I expect we'll have a very similar feature
for scsi (and maybe others).

But we do not have a way to have fields that are portable
both across devices and transports, and I think it would
be a useful addition. How would this work though? Any idea?

-- 
MST

  reply	other threads:[~2018-06-21 18:20 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07 23:09 [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net Sridhar Samudrala
2018-06-05  1:41 ` Samudrala, Sridhar
2018-06-05  2:06   ` Jason Wang
2018-06-06 18:17     ` Samudrala, Sridhar
2018-06-06 18:52       ` [Qemu-devel] [libvirt] " Ján Tomko
2018-06-06 19:39         ` Samudrala, Sridhar
2018-06-06 18:53       ` [Qemu-devel] " Michael S. Tsirkin
2018-06-05 12:33   ` Michael S. Tsirkin
2018-06-05 20:20     ` Samudrala, Sridhar
2018-06-05 20:37       ` Michael S. Tsirkin
2018-06-05 21:16     ` [Qemu-devel] [virtio-dev] " Siwei Liu
2018-06-05 21:32       ` Michael S. Tsirkin
2018-06-05 22:09         ` Siwei Liu
2018-06-12 11:47           ` Michael S. Tsirkin
2018-06-14  0:56             ` Siwei Liu
2018-06-06  2:29     ` [Qemu-devel] " Jason Wang
2018-06-12 11:54       ` Michael S. Tsirkin
2018-06-13  0:20         ` Samudrala, Sridhar
2018-06-13  2:41           ` Jason Wang
2018-06-13  2:38         ` Jason Wang
2018-06-13  4:24           ` Samudrala, Sridhar
2018-06-13  5:40             ` Jason Wang
2018-06-21 18:14               ` Michael S. Tsirkin
2018-06-22  1:07                 ` [Qemu-devel] [virtio-dev] " Siwei Liu
2018-06-22  2:30                   ` Michael S. Tsirkin
2018-06-22 19:43                     ` Siwei Liu
2018-06-22 21:47                       ` Michael S. Tsirkin
2018-06-22 22:25                         ` Siwei Liu
2018-06-22 22:28                           ` Michael S. Tsirkin
2018-06-11 17:26 ` [Qemu-devel] " Michael S. Tsirkin
2018-06-12  1:54   ` Jason Wang
2018-06-12  2:17     ` Michael S. Tsirkin
2018-06-12  5:02       ` Samudrala, Sridhar
2018-06-12 11:34         ` Michael S. Tsirkin
2018-06-13  0:08           ` [Qemu-devel] [virtio-dev] " Samudrala, Sridhar
2018-06-14  1:02             ` Siwei Liu
2018-06-14 10:02               ` Cornelia Huck
2018-06-15  1:57                 ` Siwei Liu
2018-06-15 11:48                   ` Cornelia Huck
2018-06-15 17:06                     ` Siwei Liu
2018-06-19 10:54                       ` Cornelia Huck
2018-06-19 20:09                         ` Siwei Liu
2018-06-20 14:34                           ` Cornelia Huck
2018-06-20 19:59                             ` Siwei Liu
2018-06-19 20:32                         ` Michael S. Tsirkin
2018-06-20  9:53                           ` Cornelia Huck
2018-06-20 14:11                             ` Michael S. Tsirkin
2018-06-20 16:06                               ` Cornelia Huck
2018-06-20 19:48                                 ` Michael S. Tsirkin
2018-06-21 14:59                                   ` Cornelia Huck
2018-06-21 18:20                                     ` Michael S. Tsirkin [this message]
2018-06-22 15:09                                       ` Cornelia Huck
2018-06-22 19:05                                         ` Michael S. Tsirkin
2018-06-22 20:21                                           ` Siwei Liu
2018-06-22 21:32                                             ` Michael S. Tsirkin
2018-06-22 21:57                                               ` Siwei Liu
2018-06-22 22:33                                                 ` Michael S. Tsirkin
2018-06-23  0:05                                                   ` Siwei Liu
2018-06-26 15:08                                                     ` Cornelia Huck
2018-06-26 17:50                                                       ` Michael S. Tsirkin
2018-06-27  9:11                                                         ` Cornelia Huck
2018-06-25  9:55                                           ` Cornelia Huck
2018-06-26  1:46                                             ` Michael S. Tsirkin
2018-06-26 11:55                                               ` Cornelia Huck
2018-06-26 13:54                                                 ` Michael S. Tsirkin
2018-06-22 21:43                                         ` Michael S. Tsirkin
2018-06-27 10:10                                           ` Cornelia Huck
2018-06-22  1:21                                     ` Siwei Liu
2018-06-22  2:25                                       ` Venu Busireddy
2018-06-22  2:32                                       ` Michael S. Tsirkin
2018-06-22 20:00                                         ` Siwei Liu
2018-06-22 20:03                                           ` Siwei Liu
2018-06-22 21:29                                             ` Michael S. Tsirkin
2018-06-22 21:51                                               ` Siwei Liu
2018-06-22 22:25                                                 ` Michael S. Tsirkin
2018-06-22 23:40                                                   ` Siwei Liu
2018-06-23  0:17                                                     ` Siwei Liu
2018-06-24  1:45                                                       ` Michael S. Tsirkin
2018-06-25 17:54                                                       ` Samudrala, Sridhar
2018-06-26  1:50                                                         ` Michael S. Tsirkin
2018-06-26 15:17                                                           ` Cornelia Huck
2018-06-26 15:38                                                             ` Michael S. Tsirkin
2018-06-26 16:03                                                               ` Cornelia Huck
2018-06-26 17:42                                                                 ` Michael S. Tsirkin
2018-06-26 23:38                                                           ` Siwei Liu
2018-06-27  0:29                                                             ` Michael S. Tsirkin
2018-06-27  6:21                                                               ` Siwei Liu
2018-06-27  6:49                                                                 ` Samudrala, Sridhar
2018-06-27  7:03                                                                   ` Siwei Liu
2018-06-15  2:34                 ` Michael S. Tsirkin
2018-06-15  9:32                   ` Cornelia Huck
2018-06-15 12:31                     ` Michael S. Tsirkin
2018-06-18 13:27                       ` Cornelia Huck
2018-06-14 12:50               ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180621211712-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=aaron.f.brown@intel.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=cohuck@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=joao.m.martins@oracle.com \
    --cc=konrad.wilk@oracle.com \
    --cc=kubakici@wp.pl \
    --cc=loseweigh@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sridhar.samudrala@intel.com \
    --cc=venu.busireddy@oracle.com \
    --cc=vijay.balakrishna@oracle.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).